perf: replace graceful-fs with node:fs #11894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack canceled.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the graceful-fs dependency in favor of native node:fs, as Rspack handles file system operations on the Rust side, making the graceful-fs wrapper unnecessary. This simplification should improve build performance.
Key Changes:
- Replaced
graceful-fsimports withnode:fsin source files - Removed
graceful-fsfrom package dependencies and build configuration - Updated prebundle configuration to handle watchpack's graceful-fs dependency externally
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/rspack/tsconfig.json | Removed graceful-fs path alias from TypeScript configuration |
| packages/rspack/src/rspackOptionsApply.ts | Changed import from graceful-fs to node:fs |
| packages/rspack/src/node/NodeEnvironmentPlugin.ts | Changed import from graceful-fs to node:fs and adjusted import ordering |
| packages/rspack/prebundle.config.mjs | Removed graceful-fs from dependencies list and updated watchpack configuration to externalize it |
| packages/rspack/package.json | Removed graceful-fs and @types/graceful-fs dependencies |
| package.json | Removed graceful-fs patch from pnpm configuration |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
github-actions
bot
added
release: performance
Contributor
📦 Binary Size-limit
🙈 Size remains the same at 47.67MB |
CodSpeed Performance ReportMerging #11894 will not alter performanceComparing Summary
|
hardfist
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rspack handles file system operations in Rust side, so the
graceful-fsdependency on the Node.js side is not necessary. And modern Node.js applications rarely usegraceful-fs, this PR removes it and usesnode:fsdirectly instead.This change should make
rspack buildslightly faster.Checklist