fix: should not cache dependency instance in DynamicEntryPlugin #11888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack canceled.
|
github-actions
bot
added
release: bug fix
Contributor
📦 Binary Size-limit
❌ Size increased by 4.38KB from 47.66MB to 47.67MB (⬆️0.01%) |
SyMind
force-pushed
the
fix-removed-dependency
branch
2 times, most recently
from
0e7f548 to
3a18076
Compare
CodSpeed Performance ReportMerging #11888 will not alter performanceComparing Summary
|
SyMind
force-pushed
the
fix-removed-dependency
branch
from
3a18076 to
2478a2c
Compare
SyMind
changed the title
SyMind
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
Fix caching in DynamicEntryPlugin to store DependencyId instead of EntryDependency instances, preserving FactorizeInfo and enabling correct cleanup of dynamic entry subtrees across compilations.
- Cache DependencyId per entry/options and rebuild the mapping each compilation
- Update make() to resolve dependencies by id from the ModuleGraph
- Add a watch test case ensuring entry subtree is removed when a dynamic 404 entry disappears
Reviewed Changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/rspack_plugin_dynamic_entry/src/lib.rs | Switch to caching DependencyId behind an async mutex and adjust make() logic to reuse or recreate entry dependencies by id |
| tests/rspack-test/watchCases/entries/loader-as-dynamic-entry/rspack.config.js | Dynamic entry config and plugin to mark missing files for watch, exercising cleanup behavior |
| tests/rspack-test/watchCases/entries/loader-as-dynamic-entry/test.config.js | Test harness config for this watch case |
| tests/rspack-test/watchCases/entries/loader-as-dynamic-entry/0/404-page-loader.js | Loader producing a require of 404.js to form the subtree |
| tests/rspack-test/watchCases/entries/loader-as-dynamic-entry/2/404.js | Fixture to simulate removal of the 404 entry |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ahabhgk
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Cache DependencyId in DynamicEntryPlugin instead of EntryDependency instances to preserve build information across compilations.
Caching instances loses
FactorizeInfoand other metadata, preventing proper removal of entry dependency subtrees.Related links
Checklist