Skip to content

Conversation

@chenjiahan
Copy link
Member

Summary

Rspack has switched to the npm trusted publishing, the OTP release scripts should be removed as they are no longer used.

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings October 15, 2025 11:31
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Oct 15, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes outdated OTP (One-Time Password) authentication scripts and dependencies following Rspack's migration to npm trusted publishing. The changes eliminate the --otp command-line option, remove the OTP-specific publish function, and update documentation to reflect the new release workflow.

Key Changes:

  • Removed OTP authentication logic and retry mechanism from the publish script
  • Removed @continuous-auth/client dependency from package.json
  • Updated release documentation to reference the new workflow without OTP

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
x.mjs Removed --otp command-line option from publish command
scripts/release/publish.mjs Removed OTP-specific publish function and simplified to single publish method
package.json Removed @continuous-auth/client dependency
website/docs/en/contribute/development/releasing.md Updated workflow reference from Release Full(OTP) to Release Full
website/docs/zh/contribute/development/releasing.md Updated workflow reference from Release Full(OTP) to Release Full (Chinese version)
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@netlify
Copy link

netlify bot commented Oct 15, 2025

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit ca2e931
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/68ef86976aefd9000863487d
😎 Deploy Preview https://deploy-preview-11885--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Contributor

📦 Binary Size-limit

Comparing ca2e931 to chore(deps): update patch npm dependencies (#11874) by renovate[bot]

🙈 Size remains the same at 47.66MB

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 15, 2025

CodSpeed Performance Report

Merging #11885 will not alter performance

Comparing remove_otp_release_1015 (ca2e931) with main (10ef001)

Summary

✅ 17 untouched

@stormslowly stormslowly merged commit e8f4f05 into main Oct 15, 2025
68 of 70 checks passed
@stormslowly stormslowly deleted the remove_otp_release_1015 branch October 15, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants