test: use promise instead of done callback #11872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack canceled.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR converts test files from using the done callback pattern to using Promises, following the Jest migration guide recommendation for rstest.rs. The changes modernize the test suite by replacing callback-based asynchronous tests with Promise-based async/await patterns.
Key changes:
- Convert
it("test name", (done) => { ... })toit("test name", () => new Promise((resolve, reject) => { ... })) - Replace
done()calls withresolve()anddone(err)calls withreject(err) - Convert some tests to use async/await syntax where appropriate
- Remove unnecessary
beforeEachandafterEachcallbacks that only calleddone()
Reviewed Changes
Copilot reviewed 292 out of 292 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Multiple test files | Convert from done callback pattern to Promise-based pattern |
| setup-env.ts | Update test wrapper to use Promise pattern |
| warmup-webpack.js | Convert warmup test to Promise pattern |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
tests/rspack-test/configCases/split-chunks/runtime-chunk-async-node/c.js
Outdated
Show resolved
Hide resolved
Contributor
📦 Binary Size-limit
🙈 Size remains the same at 47.67MB |
CodSpeed Performance ReportMerging #11872 will not alter performanceComparing Summary
|
LingyuCoder
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use
promiseinstead ofdonecallback in tests.https://rstest.rs/guide/migration/jest#done-callback
Related links
Checklist