feat: eval simple expression for enum member #11859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
bot
added
release: feature
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements expression evaluation for TypeScript enum members, enabling inlining of computed enum values like arithmetic operations, unary expressions, and references to other enum members.
Key changes:
- Enhanced enum member value evaluation to handle expressions beyond simple literals
- Added comprehensive expression evaluation methods supporting arithmetic, unary operators, member references, and template literals
- Updated function signatures to pass syntax context information for proper identifier resolution
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/rspack-test/configCases/inline-enum/enum-expression/index.js | Added test cases for evaluatable enum expressions |
| tests/rspack-test/configCases/inline-enum/enum-expression/enum.ts | Added new enum with various expression types for testing |
| crates/swc_plugin_ts_collector/tests/fixture.rs | Updated closure signature to match new API |
| crates/swc_plugin_ts_collector/src/enums.rs | Implemented comprehensive expression evaluation for enum members |
| crates/rspack_loader_swc/src/lib.rs | Updated to pass syntax context to TypeScript info collection |
| crates/rspack_loader_swc/src/collect_ts_info.rs | Added syntax context parameter to collection function |
| crates/rspack_javascript_compiler/src/compiler/transform.rs | Modified transform pipeline to provide syntax context |
| crates/rspack_javascript_compiler/examples/transform.rs | Updated example to match new closure signature |
| crates/rspack_binding_api/src/swc.rs | Updated binding to match new closure signature |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
JSerFeng
approved these changes
Oct 13, 2025
Contributor
📦 Binary Size-limit
🎉 Size decreased by 274.13KB from 47.89MB to 47.62MB (⬇️0.56%) |
CodSpeed Performance ReportMerging #11859 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Eval simple expression for enum member
Related links
Checklist