Skip to content

Conversation

@CPunisher
Copy link
Contributor

Summary

This is a feedback from a user and I think it's valuable to write it into the docs.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link

netlify bot commented Oct 11, 2025

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit 4b0f362
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/68e9e37652d0300008d7ac03
😎 Deploy Preview https://deploy-preview-11838--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: document release: document related release(mr only) labels Oct 11, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds documentation for handling compatibility issues between BrowserHttpImportEsmPlugin and resolve.alias configuration in Rspack. The documentation explains that the plugin's dependency rewriting occurs before alias resolution, which can cause conflicts.

  • Added compatibility notes explaining the execution order between BrowserHttpImportEsmPlugin and resolve.alias
  • Provided example configuration showing how to skip plugin rewriting for aliased paths
  • Added the documentation in both English and Chinese versions

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
website/docs/en/api/javascript-api/browser.mdx Added English documentation for resolve.alias compatibility with example configuration
website/docs/zh/api/javascript-api/browser.mdx Added Chinese documentation for resolve.alias compatibility with example configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chenjiahan chenjiahan merged commit 5efe8a6 into main Oct 11, 2025
28 checks passed
@chenjiahan chenjiahan deleted the 10-11-docs/http-import-with-alias branch October 11, 2025 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: document release: document related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants