Skip to content

Conversation

@LingyuCoder
Copy link
Contributor

Summary

Run webpack watch cases with rspack test tools. This is part of migrating webpack test cases to rspack

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings October 9, 2025 11:02
@netlify
Copy link

netlify bot commented Oct 9, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit a73b6dd
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/68e88a7df6fc1500083fd0b6

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Oct 9, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates webpack hot module replacement (HMR) test cases to rspack by running webpack hot cases with rspack test tools. This is part of the broader effort to migrate webpack test cases to rspack for better compatibility testing.

Key changes include:

  • Removal of all webpack hot case test files from the webpack-test directory
  • Addition of rspack-specific hot case test files and snapshots
  • Updates to test configuration files to use rspack test tools and fake document types

Reviewed Changes

Copilot reviewed 136 out of 445 changed files in this pull request and generated no comments.

File Description
tests/webpack-test/hotCases/* Removed all webpack hot case test files as they are being migrated
tests/rspack-test/hotCases//snapshots/web/.snap.txt Added rspack test snapshots for hot case scenarios
tests/rspack-test/hotCases/*/test.config.js Added/updated test configuration files for rspack compatibility
tests/rspack-test/hotCases/*/index.js Updated test files to work with rspack test infrastructure

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2025

📦 Binary Size-limit

Comparing a73b6dd to fix: should use external source as name hint (#11825) by Fy

❌ Size increased by 128bytes from 47.89MB to 47.89MB (⬆️0.00%)

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 9, 2025

CodSpeed Performance Report

Merging #11826 will not alter performance

Comparing test/hot-cases (a73b6dd) with main (61dfbf4)

Summary

✅ 17 untouched

@LingyuCoder LingyuCoder requested a review from hardfist October 10, 2025 04:52
@LingyuCoder LingyuCoder enabled auto-merge (squash) October 10, 2025 05:08
@LingyuCoder LingyuCoder merged commit 95357f7 into main Oct 10, 2025
44 checks passed
@LingyuCoder LingyuCoder deleted the test/hot-cases branch October 10, 2025 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants