Skip to content

Conversation

@LingyuCoder
Copy link
Contributor

Summary

Run webpack watch cases with rspack test tools. This is part of migrating webpack test cases to rspack

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings October 9, 2025 06:31
@netlify
Copy link

netlify bot commented Oct 9, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 54f7d2a
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/68e7662c46a891000814419f

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Oct 9, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates webpack watch test cases to use rspack test tools. The changes adapt webpack test configurations to work with rspack's testing infrastructure and update the test framework to support watch case testing.

  • Remove old native watcher and incremental watch test runners for webpack tests
  • Add rspack-compatible configuration files for watch test cases with cache settings
  • Update test tools to support ignoreNotFriendlyForIncrementalWarnings configuration option

Reviewed Changes

Copilot reviewed 20 out of 385 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/rspack-test/NativeWatcher-webpack.test.js Removed old native watcher test runner
tests/rspack-test/Incremental-watch-webpack.test.js Removed old incremental watch test runner
tests/rspack-test/watchCases/*/webpack.config.js Updated cache configurations to use rspack-compatible syntax
tests/rspack-test/watchCases/*/test.config.js Added test configuration files with incremental warning suppression
packages/rspack-test-tools/src/type.ts Added ignoreNotFriendlyForIncrementalWarnings to test configuration type
packages/rspack-test-tools/src/case/watch.ts Updated watch processors to use test config for warning suppression
packages/rspack-test-tools/src/case/incremental.ts Simplified incremental test creator by removing hardcoded options
packages/rspack-test-tools/src/test/creator.ts Added whitespace formatting
packages/rspack-test-tools/etc/test-tools.api.md Updated API documentation with new test config option

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2025

📦 Binary Size-limit

Comparing 54f7d2a to chore(deps): update swc (#11747) by renovate[bot]

❌ Size increased by 4.63KB from 47.89MB to 47.89MB (⬆️0.01%)

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 9, 2025

CodSpeed Performance Report

Merging #11821 will not alter performance

Comparing test/watch-cases (54f7d2a) with main (ce8a706)

Summary

✅ 17 untouched

@LingyuCoder LingyuCoder requested a review from hardfist October 9, 2025 08:01
@LingyuCoder LingyuCoder merged commit c95a9c0 into main Oct 9, 2025
43 checks passed
@LingyuCoder LingyuCoder deleted the test/watch-cases branch October 9, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants