-
-
Notifications
You must be signed in to change notification settings - Fork 746
test: run webpack example cases with test tools #11820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for rspack canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enables webpack example cases to run with rspack test tools, allowing migration of webpack test cases to rspack. The changes update import statements from webpack to rspack, add necessary dependencies, and create a new test runner for example cases.
- Updates webpack example configs to use
@rspack/coreinstead of local webpack imports - Removes or updates test filters to enable previously disabled example tests
- Creates new example test runner and integrates it into the rspack test suite
Reviewed Changes
Copilot reviewed 31 out of 34 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/webpack-test/jest.config.js | Comments out Examples.test.js to avoid conflicts |
| tests/webpack-examples/*/webpack.config.js | Updates imports from local webpack to @rspack/core |
| tests/webpack-examples/*/test.filter.js | Removes filters blocking tests or adds specific skip reasons |
| tests/webpack-examples/package.json | Adds @rspack/core and other dependencies needed for examples |
| tests/rspack-test/jest.config.js | Adds Example.test.js to test suite |
| tests/rspack-test/Example.test.js | Creates new test runner for example cases |
| packages/rspack-test-tools/src/case/example.ts | Implements example case processor |
| packages/rspack-test-tools/src/case/index.ts | Exports createExampleCase function |
| packages/rspack-test-tools/src/test/tester.ts | Improves error handling with better error messages |
| packages/rspack-test-tools/etc/test-tools.api.md | Documents new createExampleCase API |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
📦 Binary Size-limit
❌ Size increased by 4.63KB from 47.89MB to 47.89MB (⬆️0.01%) |
CodSpeed Performance ReportMerging #11820 will not alter performanceComparing Summary
|
Summary
Run webpack example cases with rspack test tools. This is part of migrating webpack test cases to rspack
Related links
Checklist