Skip to content

Conversation

@LingyuCoder
Copy link
Contributor

Summary

Run webpack example cases with rspack test tools. This is part of migrating webpack test cases to rspack

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings October 9, 2025 05:22
@netlify
Copy link

netlify bot commented Oct 9, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 2d6b3c0
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/68e746836b89f9000885937a

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Oct 9, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables webpack example cases to run with rspack test tools, allowing migration of webpack test cases to rspack. The changes update import statements from webpack to rspack, add necessary dependencies, and create a new test runner for example cases.

  • Updates webpack example configs to use @rspack/core instead of local webpack imports
  • Removes or updates test filters to enable previously disabled example tests
  • Creates new example test runner and integrates it into the rspack test suite

Reviewed Changes

Copilot reviewed 31 out of 34 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tests/webpack-test/jest.config.js Comments out Examples.test.js to avoid conflicts
tests/webpack-examples/*/webpack.config.js Updates imports from local webpack to @rspack/core
tests/webpack-examples/*/test.filter.js Removes filters blocking tests or adds specific skip reasons
tests/webpack-examples/package.json Adds @rspack/core and other dependencies needed for examples
tests/rspack-test/jest.config.js Adds Example.test.js to test suite
tests/rspack-test/Example.test.js Creates new test runner for example cases
packages/rspack-test-tools/src/case/example.ts Implements example case processor
packages/rspack-test-tools/src/case/index.ts Exports createExampleCase function
packages/rspack-test-tools/src/test/tester.ts Improves error handling with better error messages
packages/rspack-test-tools/etc/test-tools.api.md Documents new createExampleCase API
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2025

📦 Binary Size-limit

Comparing 2d6b3c0 to chore(deps): update swc (#11747) by renovate[bot]

❌ Size increased by 4.63KB from 47.89MB to 47.89MB (⬆️0.01%)

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 9, 2025

CodSpeed Performance Report

Merging #11820 will not alter performance

Comparing test/example-cases (2d6b3c0) with main (fb5b701)

Summary

✅ 17 untouched

@LingyuCoder LingyuCoder requested a review from hardfist October 9, 2025 05:53
@LingyuCoder LingyuCoder enabled auto-merge (squash) October 9, 2025 05:53
@LingyuCoder LingyuCoder merged commit ce8a706 into main Oct 9, 2025
47 checks passed
@LingyuCoder LingyuCoder deleted the test/example-cases branch October 9, 2025 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants