fix(loader-runner): add missing break statements in switch cases #11794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
team
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes missing break statements in switch cases to prevent unintended fallthrough behavior and enables Biome's noFallthroughSwitchClause linting rule to prevent similar issues in the future.
- Adds missing
breakstatements to three switch case blocks across the codebase - Enables the
noFallthroughSwitchClauserule in Biome configuration to enforce proper switch case handling
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/rspack/src/logging/createConsoleLogger.ts | Adds break statement to prevent fallthrough in logging switch case |
| packages/rspack/src/loader-runner/worker.ts | Adds break statement to loader state switch case |
| packages/rspack/src/loader-runner/index.ts | Adds break statement to GetLogger request type case |
| biome.jsonc | Enables noFallthroughSwitchClause rule to prevent future fallthrough issues |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
github-actions
bot
added
the
release: bug fix
✅ Deploy Preview for rspack canceled.
|
Contributor
📦 Binary Size-limit
❌ Size increased by 8.50KB from 47.89MB to 47.90MB (⬆️0.02%) |
CodSpeed Performance ReportMerging #11794 will not alter performanceComparing Summary
|
SyMind
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
noFallthroughSwitchClauserule to disallow fallthrough ofswitchclauses.Related links
Fix #11771
Checklist