test(benchmark): add basic sourcemap benchmark

h-a-n-a · h-a-n-a · commit b2457f73d3a3 · 2025-01-23T16:22:07.000+08:00
diff --git a/crates/rspack/src/builder/builder_context.rs b/crates/rspack/src/builder/builder_context.rs
@@ -159,9 +159,27 @@ impl BuilderContext {
 
       // DevTool plugins
       BuiltinPluginOptions::SourceMapDevToolPlugin(options) => {
+        plugins.push(
+          rspack_plugin_devtool::SourceMapDevToolModuleOptionsPlugin::new(
+            rspack_plugin_devtool::SourceMapDevToolModuleOptionsPluginOptions {
+              module: options.module,
+              cheap: !options.columns,
+            },
+          )
+          .boxed(),
+        );
         plugins.push(rspack_plugin_devtool::SourceMapDevToolPlugin::new(options).boxed());
       }
       BuiltinPluginOptions::EvalSourceMapDevToolPlugin(options) => {
+        plugins.push(
+          rspack_plugin_devtool::SourceMapDevToolModuleOptionsPlugin::new(
+            rspack_plugin_devtool::SourceMapDevToolModuleOptionsPluginOptions {
+              module: options.module,
+              cheap: !options.columns,
+            },
+          )
+          .boxed(),
+        );
         plugins.push(rspack_plugin_devtool::EvalSourceMapDevToolPlugin::new(options).boxed());
       }
       BuiltinPluginOptions::EvalDevToolModulePlugin(options) => {
diff --git a/crates/rspack/tests/basic.rs b/crates/rspack/tests/basic.rs
@@ -1,4 +1,4 @@
-use rspack::builder::Builder as _;
+use rspack::builder::{Builder as _, Devtool};
 use rspack_core::Compiler;
 use rspack_paths::Utf8Path;
 
@@ -17,3 +17,24 @@ async fn basic() {
   let asset = &compiler.compilation.assets().get("main.js").unwrap();
   assert_eq!(asset.source.as_ref().unwrap().source(), "console.log(123);");
 }
+
+#[tokio::test(flavor = "multi_thread")]
+async fn basic_sourcemap() {
+  let mut compiler = Compiler::builder()
+    .context(Utf8Path::new(env!("CARGO_MANIFEST_DIR")).join("tests/fixtures/basic"))
+    .entry("main", "./src/index.js")
+    .devtool(Devtool::SourceMap)
+    .build();
+
+  compiler.build().await.unwrap();
+
+  let errors: Vec<_> = compiler.compilation.get_errors().collect();
+  assert!(errors.is_empty());
+
+  let asset = &compiler.compilation.assets().get("main.js").unwrap();
+  assert_eq!(
+    asset.source.as_ref().unwrap().source(),
+    "console.log(123);\n//# sourceMappingURL=main.js.map"
+  );
+  assert!(compiler.compilation.assets().get("main.js.map").is_some());
+}
diff --git a/tasks/benchmark/benches/basic.rs b/tasks/benchmark/benches/basic.rs
@@ -3,7 +3,7 @@
 
 use std::sync::Arc;
 
-use rspack::builder::Builder as _;
+use rspack::builder::{Builder as _, Devtool};
 use rspack_benchmark::{criterion_group, criterion_main, Criterion};
 use rspack_core::Compiler;
 use rspack_fs::{MemoryFileSystem, ReadableFileSystem, WritableFileSystem};
@@ -12,15 +12,23 @@ use tokio::runtime::Builder;
 trait FileSystem: ReadableFileSystem + WritableFileSystem + Send + Sync {}
 impl<T: ReadableFileSystem + WritableFileSystem + Send + Sync> FileSystem for T {}
 
-async fn basic(fs: Arc<dyn FileSystem>) {
-  let mut compiler = Compiler::builder()
+async fn basic(fs: Arc<dyn FileSystem>, sm: bool) {
+  let mut builder = Compiler::builder();
+
+  builder
     .context("/")
     .entry("main", "./src/index.js")
     .input_filesystem(fs.clone())
-    .output_filesystem(fs.clone())
-    .build();
+    .output_filesystem(fs.clone());
+
+  if sm {
+    builder.devtool(Devtool::SourceMap);
+  }
+
+  let mut compiler = builder.build();
 
   compiler.run().await.unwrap();
+
   assert!(compiler
     .compilation
     .get_errors()
@@ -29,28 +37,36 @@ async fn basic(fs: Arc<dyn FileSystem>) {
 }
 
 pub fn criterion_benchmark(c: &mut Criterion) {
+  let rt = Builder::new_multi_thread().build().unwrap();
+
+  let fs = MemoryFileSystem::default();
+  rt.block_on(async {
+    fs.create_dir_all("/src".into()).await.unwrap();
+    fs.write(
+      "/src/index.js".into(),
+      br#"if(process.env.NODE_ENV === "production") {
+  console.log(123);
+} else {
+  console.log(456);
+}
+"#,
+    )
+    .await
+    .unwrap();
+  });
+  let fs = Arc::new(fs);
+
   c.bench_function("basic", |b| {
-    let rt = Builder::new_multi_thread().build().unwrap();
-
-    let fs = MemoryFileSystem::default();
-    rt.block_on(async {
-      fs.create_dir_all("/src".into()).await.unwrap();
-      fs.write(
-        "/src/index.js".into(),
-        br#"if(process.env.NODE_ENV === "production") {
-    console.log(123);
-  } else {
-    console.log(456);
-  }
-  "#,
-      )
-      .await
-      .unwrap();
+    b.to_async(&rt).iter(|| {
+      let fs = fs.clone();
+      basic(fs, false)
     });
-    let fs = Arc::new(fs);
+  });
+
+  c.bench_function("basic_sourcemap", |b| {
     b.to_async(&rt).iter(|| {
       let fs = fs.clone();
-      basic(fs)
+      basic(fs, true)
     });
   });
 }
