fix: rename napi to getNumberOfEntryModules

colinaaa · colinaaa · commit 672258ec150d · 2025-01-21T17:34:13.000+08:00
diff --git a/crates/node_binding/binding.d.ts b/crates/node_binding/binding.d.ts
@@ -72,7 +72,7 @@ export declare class JsChunk {
 export declare class JsChunkGraph {
   getChunkModules(chunk: JsChunk): JsModule[]
   getChunkEntryModules(chunk: JsChunk): JsModule[]
-  getNumberOfChunkEntryModules(chunk: JsChunk): number
+  getNumberOfEntryModules(chunk: JsChunk): number
   getChunkEntryDependentChunksIterable(chunk: JsChunk): JsChunk[]
   getChunkModulesIterableBySourceType(chunk: JsChunk, sourceType: string): JsModule[]
   getModuleChunks(module: JsModule): JsChunk[]
diff --git a/crates/rspack_binding_values/src/chunk_graph.rs b/crates/rspack_binding_values/src/chunk_graph.rs
@@ -62,13 +62,13 @@ impl JsChunkGraph {
   }
 
   #[napi(ts_return_type = "number")]
-  pub fn get_number_of_chunk_entry_modules(&self, chunk: &JsChunk) -> Result<u32> {
+  pub fn get_number_of_entry_modules(&self, chunk: &JsChunk) -> Result<u32> {
     let compilation = self.as_ref()?;
 
     Ok(
       compilation
         .chunk_graph
-        .get_number_of_chunk_entry_modules(&chunk.chunk_ukey) as u32,
+        .get_number_of_entry_modules(&chunk.chunk_ukey) as u32,
     )
   }
 
diff --git a/crates/rspack_core/src/chunk_graph/chunk_graph_chunk.rs b/crates/rspack_core/src/chunk_graph/chunk_graph_chunk.rs
@@ -215,13 +215,6 @@ impl ChunkGraph {
     chunk_graph_chunk.entry_modules.keys().copied().collect()
   }
 
-  pub fn get_number_of_chunk_entry_modules(&self, chunk_ukey: &ChunkUkey) -> usize {
-    self
-      .expect_chunk_graph_chunk(chunk_ukey)
-      .entry_modules
-      .len()
-  }
-
   pub fn get_chunk_entry_modules_with_chunk_group_iterable(
     &self,
     chunk_ukey: &ChunkUkey,
diff --git a/packages/rspack/src/ChunkGraph.ts b/packages/rspack/src/ChunkGraph.ts
@@ -33,7 +33,7 @@ export class ChunkGraph {
 	}
 
 	getNumberOfEntryModules(chunk: Chunk): number {
-		return this.#inner.getNumberOfChunkEntryModules(Chunk.__to_binding(chunk));
+		return this.#inner.getNumberOfEntryModules(Chunk.__to_binding(chunk));
 	}
 
 	getChunkEntryDependentChunksIterable(chunk: Chunk): Iterable<Chunk> {

Original file line number	Diff line number	Diff line change
`@@ -62,13 +62,13 @@ impl JsChunkGraph {`
`62`	`62`	`}`
`63`	`63`
`64`	`64`	`#[napi(ts_return_type = "number")]`
`65`		`- pub fn get_number_of_chunk_entry_modules(&self, chunk: &JsChunk) -> Result<u32> {`
	`65`	`+ pub fn get_number_of_entry_modules(&self, chunk: &JsChunk) -> Result<u32> {`
`66`	`66`	`let compilation = self.as_ref()?;`
`67`	`67`
`68`	`68`	`Ok(`
`69`	`69`	`compilation`
`70`	`70`	`.chunk_graph`
`71`		`- .get_number_of_chunk_entry_modules(&chunk.chunk_ukey) as u32,`
	`71`	`+ .get_number_of_entry_modules(&chunk.chunk_ukey) as u32,`
`72`	`72`	`)`
`73`	`73`	`}`
`74`	`74`
Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ export class ChunkGraph {`
`33`	`33`	`}`
`34`	`34`
`35`	`35`	`getNumberOfEntryModules(chunk: Chunk): number {`
`36`		`- return this.#inner.getNumberOfChunkEntryModules(Chunk.__to_binding(chunk));`
	`36`	`+ return this.#inner.getNumberOfEntryModules(Chunk.__to_binding(chunk));`
`37`	`37`	`}`
`38`	`38`
`39`	`39`	`getChunkEntryDependentChunksIterable(chunk: Chunk): Iterable<Chunk> {`