Repository navigation
feat(client): sort bundle module trees by size - #2101
Merged
yifancong merged 1 commit intoOct 16, 2026
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
|
Thank you for your code contribution. You need to sign the license/cla above. |
yifancong
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #2049.
The Bundle Size module tree shows file and folder sizes, but it does not let users rank siblings by those sizes when investigating large bundles.
Changes
Validation on Windows with Node 22.23.2:
pnpm --filter @rsdoctor/client run test: 78 passed.rs check --type-check: lint, type and format checks passed.rs test run module-tree-sortine2e: 3 passed in Chrome; all three fail on the baseline UI because the sorting control is absent.The browser fixture normalizes emitted absolute source-map paths to obtain real bundled sizes on Windows. No production source-map behavior is changed.
Screenshots from the same generated report (the
metricsfiles exchange positions when changing the selected size):