Skip to content

Comments

fix(plugin-vue): remove webpack dependency#7148

Merged
chenjiahan merged 2 commits intomainfrom
vue_dep_0205
Feb 5, 2026
Merged

fix(plugin-vue): remove webpack dependency#7148
chenjiahan merged 2 commits intomainfrom
vue_dep_0205

Conversation

@chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Feb 5, 2026

Summary

Upgraded rspack-vue-loader from version 17.4.5 to 17.5.0 to remove webpack dependency.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings February 5, 2026 07:30
@chatgpt-codex-connector
Copy link

chatgpt-codex-connector bot commented Feb 5, 2026

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Feb 5, 2026

Summary of Changes

Hello @chenjiahan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to streamline the dependency management within the plugin-vue package by eliminating its direct reliance on webpack. This is achieved through an upgrade of the rspack-vue-loader to a version that no longer requires webpack as a peer or direct dependency, thereby simplifying the project's overall dependency graph and aligning it more closely with the rspack ecosystem.

Highlights

  • Dependency Upgrade: The rspack-vue-loader dependency has been upgraded from version ^17.4.5 to ^17.5.0 in packages/plugin-vue/package.json.
  • Webpack Dependency Removal: The direct webpack dependency has been removed from packages/plugin-vue/package.json. This change is reflected in the pnpm-lock.yaml where webpack is no longer listed as a dependency for plugin-vue and is also removed as a peer dependency for rspack-vue-loader.
  • Lockfile Updates: The pnpm-lock.yaml file has been updated to reflect the new rspack-vue-loader version and its adjusted internal dependency tree, which now includes @rspack/core and @rspack/lite-tapable while removing watchpack and webpack from its own dependencies.
Changelog
  • packages/plugin-vue/package.json
    • Updated rspack-vue-loader dependency from ^17.4.5 to ^17.5.0.
    • Removed webpack dependency (^5.104.1).
  • pnpm-lock.yaml
    • Updated rspack-vue-loader entry to version 17.5.0.
    • Removed webpack as a direct dependency for packages/plugin-vue.
    • Adjusted rspack-vue-loader's peer dependencies, removing webpack and adding @rspack/core.
    • Updated rspack-vue-loader's internal dependencies, adding @rspack/lite-tapable and removing watchpack and webpack.
Activity
  • The pull request was opened by chenjiahan.
  • The author provided a summary of the changes and a checklist, with all items currently unchecked.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Feb 5, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades rspack-vue-loader to version 17.5.0, which successfully removes the explicit webpack dependency from the plugin-vue package. The changes in package.json and the corresponding updates in pnpm-lock.yaml are correct and align with the goal of the PR. This is a good dependency cleanup. The changes look good to me.

Copilot AI reviewed Feb 5, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades rspack-vue-loader from version 17.4.5 to 17.5.0 to eliminate the unnecessary webpack dependency from the @rsbuild/plugin-vue package. The new version of rspack-vue-loader (v17.5.0) removes webpack as a peer dependency and instead uses @rspack/core as an optional peer dependency, aligning better with the Rsbuild ecosystem.

Changes:

  • Upgraded rspack-vue-loader from ^17.4.5 to ^17.5.0 in package.json
  • Removed the webpack dependency that was previously required
  • Updated pnpm-lock.yaml with the new rspack-vue-loader version, which now uses @rspack/lite-tapable instead of watchpack

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
packages/plugin-vue/package.json Upgraded rspack-vue-loader to ^17.5.0 and removed webpack dependency
pnpm-lock.yaml Updated lock file with new rspack-vue-loader version and its dependencies, removed webpack-related entries
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chenjiahan chenjiahan merged commit ba043ec into main Feb 5, 2026
5 checks passed
@chenjiahan chenjiahan deleted the vue_dep_0205 branch February 5, 2026 07:48
@chenjiahan chenjiahan mentioned this pull request Feb 5, 2026
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release: bug fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@chenjiahan