chore: remove webpack dev dependency from core#7146
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Summary of ChangesHello @chenjiahan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a targeted cleanup within the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the unused webpack dev dependency from the @rsbuild/core package. The changes are correct and consistent, including removing the dependency from package.json, the externals configuration, and updating the lockfile. This is a good cleanup.
There was a problem hiding this comment.
Pull request overview
This PR removes the unused webpack dev dependency from the @rsbuild/core package. The project has migrated to Rspack and no longer requires webpack as a dependency.
Changes:
- Removed
webpackfrom devDependencies inpackages/core/package.json - Removed
webpackentry from the lockfilepnpm-lock.yaml - Removed
webpackfrom the externals configuration inpackages/core/rslib.config.ts
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pnpm-lock.yaml | Removed webpack dependency entry from lockfile |
| packages/core/package.json | Removed webpack from devDependencies |
| packages/core/rslib.config.ts | Removed webpack from the externals array |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 participant
Summary
Remove the unused
webpack devdependency from core.Checklist