docs: enhance upgrade guide with Agent Skills instructions#7141
docs: enhance upgrade guide with Agent Skills instructions#7141chenjiahan merged 2 commits intomainfrom
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Summary of ChangesHello @chenjiahan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the Rsbuild v1 to v2 upgrade documentation by introducing new sections that guide users through the migration process. It highlights the utility of Coding Agent Skills for automated assistance, provides explicit steps for updating core Rsbuild packages and plugins, and clarifies the underlying dependency on Rspack v2. The aim is to streamline the upgrade experience and ensure users have clear, actionable instructions. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request enhances the upgrade guide by adding instructions for using Agent Skills and providing clearer steps for manual upgrades. The changes are well-structured and improve the documentation. I've suggested a couple of minor improvements to the links in the documentation for better navigation.
There was a problem hiding this comment.
Pull request overview
Enhances the v1 → v2 upgrade documentation by adding Agent Skills guidance and more explicit dependency upgrade steps, plus a small dev-dependency bump.
Changes:
- Added “Agent Skills” instructions and explicit Rsbuild/plugin upgrade commands in both EN/ZH upgrade guides.
- Reorganized the Rspack v2 guidance into its own section with clarified dependency notes.
- Bumped
heading-casefrom^1.0.4to^1.0.6(and updatedpnpm-lock.yamlaccordingly).
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| website/docs/zh/guide/upgrade/v1-to-v2.mdx | Adds Agent Skills + explicit v2 upgrade steps (contains a malformed GitHub link). |
| website/docs/en/guide/upgrade/v1-to-v2.mdx | Adds Agent Skills + explicit v2 upgrade steps (suggest adding a doc link for clarity). |
| package.json | Updates heading-case devDependency version. |
| pnpm-lock.yaml | Locks heading-case to 1.0.6. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ## 使用 Agent Skills | ||
|
|
||
| Rsbuild v2 现在依赖 [@rspack/core](https://www.npmjs.com/package/@rspack/core) v2。 | ||
| 如果你在使用支持 Skills 的 Coding Agent,可以安装 [rsbuild-v2-upgrade](https://github.com/rstackjs/agent-skills?rsbuild-v2-upgrade) 技能来辅助完成 v1 到 v2 的升级流程。 |
There was a problem hiding this comment.
The rsbuild-v2-upgrade link URL looks malformed (https://github.com/rstackjs/agent-skills?rsbuild-v2-upgrade). As written it won’t navigate to the intended section on GitHub (it’s treated as an unknown query string). Update it to a proper URL/anchor (e.g. the README section for #rsbuild-v2-upgrade).
| 如果你在使用支持 Skills 的 Coding Agent,可以安装 [rsbuild-v2-upgrade](https://github.com/rstackjs/agent-skills?rsbuild-v2-upgrade) 技能来辅助完成 v1 到 v2 的升级流程。 | |
| 如果你在使用支持 Skills 的 Coding Agent,可以安装 [rsbuild-v2-upgrade](https://github.com/rstackjs/agent-skills#rsbuild-v2-upgrade) 技能来辅助完成 v1 到 v2 的升级流程。 |
Deploying rsbuild with
|
| Latest commit: |
7abda02
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e24da269.rsbuild-v2.pages.dev |
| Branch Preview URL: | https://upgrade-guide-skills-0204.rsbuild-v2.pages.dev |
Summary
Expanded the upgrade guide with detailed instructions, including using Coding Agent Skills to assist with the migration, explicit upgrade steps for
@rsbuild/coreand plugins, and clarified the dependency on@rspack/corev2.Related Links
Checklist