Skip to content

Comments

feat(deps): upgrade @rspack/core to 2.0.0-beta.0#7134

Merged
chenjiahan merged 2 commits intomainfrom
update_rspack_2.0.0-beta.0
Feb 3, 2026
Merged

feat(deps): upgrade @rspack/core to 2.0.0-beta.0#7134
chenjiahan merged 2 commits intomainfrom
update_rspack_2.0.0-beta.0

Conversation

@chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Feb 3, 2026 •
edited
Loading

Summary

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings February 3, 2026 10:36
@chatgpt-codex-connector
Copy link

chatgpt-codex-connector bot commented Feb 3, 2026

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Feb 3, 2026

Summary of Changes

Hello @chenjiahan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a significant version bump for the @rspack/core package to its 2.0.0-beta.0 release. This upgrade necessitates updates to the project's dependency lockfile and a minor code adjustment to align with changes in how compiler options are structured within the Rspack ecosystem. The overall impact is to bring the project up to date with the latest beta features and improvements from the Rspack core.

Highlights

  • Dependency Upgrade: The core dependency @rspack/core has been upgraded from version 2.0.0-alpha.1 to 2.0.0-beta.0.
  • Configuration Access Change: The way outputModule is accessed within the EsmRunner has been updated to reflect a potential API change in @rspack/core, moving from compilerOptions.experiments?.outputModule to compilerOptions.output.module.
  • Lockfile Updates: The pnpm-lock.yaml file has been extensively updated to reflect the new @rspack/core beta version and its associated platform-specific bindings, as well as other dependent packages like css-loader, html-rspack-plugin, postcss-loader, rspack-chain, and rspack-manifest-plugin.
Changelog
  • packages/core/package.json
    • Updated @rspack/core dependency from 2.0.0-alpha.1 to 2.0.0-beta.0.
  • packages/core/src/server/runner/esm.ts
    • Modified outputModule access path from _options.compilerOptions.experiments?.outputModule to _options.compilerOptions.output.module.
  • pnpm-lock.yaml
    • Updated @rspack/core and all its platform-specific binding packages (e.g., binding-darwin-arm64, binding-linux-x64-gnu, binding-win32-x64-msvc, etc.) to version 2.0.0-beta.0.
    • Adjusted references to @rspack/core within other packages like css-loader, html-rspack-plugin, postcss-loader, rspack-chain, and rspack-manifest-plugin to point to the new beta version.
Activity
  • The pull request was created by chenjiahan.
  • The PR description includes a checklist, but no items are marked as completed.
  • No human activity (comments, reviews, etc.) has been recorded yet for this pull request.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Feb 3, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades @rspack/core to 2.0.0-beta.0 and updates the code to reflect API changes in the new version. The change in packages/core/src/server/runner/esm.ts is correct. I've left one comment regarding a missed update in a related file that also uses the deprecated API.

Copilot AI reviewed Feb 3, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Upgrades the Rsbuild core bundler dependency to @rspack/[email protected] and adapts server-side bundle execution logic to align with the updated Rspack options shape.

Changes:

  • Bump @rspack/core from 2.0.0-alpha.1 to 2.0.0-beta.0 in packages/core.
  • Update pnpm lockfile to reflect the new Rspack beta bindings and dependency graph.
  • Adjust ESM runner logic to read the ESM output flag from compilerOptions.output.module.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

File Description
pnpm-lock.yaml Updates lockfile entries for @rspack/[email protected] and associated platform bindings/snapshots.
packages/core/src/server/runner/esm.ts Switches ESM output detection to compilerOptions.output.module to match updated compiler options.
packages/core/package.json Bumps @rspack/core dependency to 2.0.0-beta.0.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chenjiahan chenjiahan merged commit af320c1 into main Feb 3, 2026
6 checks passed
@chenjiahan chenjiahan deleted the update_rspack_2.0.0-beta.0 branch February 3, 2026 10:43
@chenjiahan chenjiahan mentioned this pull request Feb 3, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release: feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@chenjiahan