feat(deps): update @rspack/core to ^1.7.5#7129
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Summary of ChangesHello @chenjiahan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on upgrading the core Rspack dependency to its latest version, Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the @rspack/core dependency to version ^1.7.5. The changes primarily involve updating end-to-end tests to accommodate the new output behavior of Rspack, specifically concerning how Unicode characters are escaped. The modifications in the tests appear correct and necessary. I've provided a few suggestions to enhance the maintainability of the tests by refactoring hardcoded strings.
There was a problem hiding this comment.
Pull request overview
Updates the @rspack/core dependency from ~1.7.1 to ^1.7.5, which changes from a locked minor version to allowing patch and minor updates. The PR also updates test assertions to reflect behavioral changes in the newer Rspack version regarding emoji/Unicode character handling in output files.
Changes:
- Updates @rspack/core dependency version constraint in package.json
- Modifies test expectations to match new Unicode encoding behavior for emojis and special characters in build output
- Converts affected tests from
test()torspackTest()to properly scope version-specific behavior
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/core/package.json | Updates @rspack/core dependency from ~1.7.1 to ^1.7.5 |
| e2e/cases/output/charset/index.test.ts | Updates test expectations for ASCII charset and UTF-8 encoding behavior, converting tests to rspackTest() |
| e2e/cases/output/charset-emoji-filename/index.test.ts | Updates test expectations for emoji filename handling and converts test to rspackTest() |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 participant
Summary
Update @rspack/core to ^1.7.5
Related Links
Checklist