Skip to content

Comments

chore: bundle dependency @rspack/lite-tapable#7115

Merged
chenjiahan merged 1 commit intomainfrom
bundle_lite_tapable_0202
Feb 2, 2026
Merged

chore: bundle dependency @rspack/lite-tapable#7115
chenjiahan merged 1 commit intomainfrom
bundle_lite_tapable_0202

Conversation

@chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Feb 2, 2026

Summary

Bundle the dependency @rspack/lite-tapable:

  • Make @rsbuild/core depend on fewer packages.
  • This package is small enough and fully pure, so inlining it is faster than doing a require.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings February 2, 2026 07:41
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Feb 2, 2026

Summary of Changes

Hello @chenjiahan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on optimizing the @rsbuild/core package by bundling the small and pure @rspack/lite-tapable dependency directly into it. This change aims to reduce the overall number of external dependencies, thereby improving performance by making inlining faster than dynamic require calls. Additionally, it includes an update to a page data fetching hook in the website theme.

Highlights

  • Dependency Removal: The @rspack/lite-tapable dependency has been removed from packages/core/package.json and pnpm-lock.yaml.
  • Prebundling Configuration Update: The @rspack/lite-tapable entry has been removed from the externals configuration in packages/core/prebundle.config.ts, indicating it is no longer treated as an external dependency during the prebundling process.
  • API Usage Update: In website/theme/index.tsx, the usePageData hook has been replaced with usePage from @rspress/core/runtime.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Feb 2, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request bundles the @rspack/lite-tapable dependency into @rsbuild/core, which is a good move to reduce the number of dependencies and potentially improve performance. The changes in packages/core/package.json and packages/core/prebundle.config.ts are correct and achieve this goal.

However, I noticed a change in website/theme/index.tsx that refactors the usage of usePageData to usePage. This seems unrelated to the main purpose of the PR. I've left a comment suggesting to move this to a separate pull request to keep this one focused.

Overall, the main change is solid.

@chenjiahan chenjiahan merged commit 4dd0262 into main Feb 2, 2026
13 checks passed
@chenjiahan chenjiahan deleted the bundle_lite_tapable_0202 branch February 2, 2026 07:50
@chenjiahan chenjiahan mentioned this pull request Feb 2, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@chenjiahan