docs: enable Rspress's new llms generation#7114
Conversation
Summary of ChangesHello @chenjiahan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the documentation site's build configuration to reflect a change in how Rspress handles LLMs generation. The external Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly migrates the documentation website from using @rspress/plugin-llms to the new built-in llms feature in Rspress. The changes involve removing the plugin dependency from package.json and pnpm-lock.yaml, and updating rspress.config.ts to remove the plugin import and usage, while enabling the feature with llms: true. The changes are clean, straightforward, and align with the stated goal. I see no issues with this update.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 765512c8c7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Deploying rsbuild with
|
| Latest commit: |
3bced7c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e642cc2c.rsbuild-v2.pages.dev |
| Branch Preview URL: | https://new-llms-0202.rsbuild-v2.pages.dev |
There was a problem hiding this comment.
Pull request overview
This PR migrates the docs site from using @rspress/plugin-llms to using Rspress’s built-in llms generation feature.
Changes:
- Removed
pluginLlms()fromwebsite/rspress.config.tsand enabledllms: truein the config. - Removed
@rspress/plugin-llmsfromwebsite/package.json. - Updated
pnpm-lock.yamlto drop@rspress/plugin-llmsfrom the lockfile.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| website/rspress.config.ts | Removes the LLMS plugin and enables the built-in llms flag. |
| website/package.json | Drops @rspress/plugin-llms from devDependencies. |
| pnpm-lock.yaml | Removes @rspress/plugin-llms entries from the lockfile. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 participant
Summary
Removes the
@rspress/plugin-llmsdependency from the project and its configuration, and instead enables thellmsfeature directly.Related Links
Checklist