fix(plugin-vue): failed to split chunks with Rsbuild v1#7112
fix(plugin-vue): failed to split chunks with Rsbuild v1#7112chenjiahan merged 2 commits intomainfrom
Conversation
Summary of ChangesHello @chenjiahan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue where the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a8916617e6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to fix an issue where splitChunks configuration in @rsbuild/plugin-vue was not working correctly with Rsbuild v1. The changes include adding a dev dependency for testing against Rsbuild v1, updating a snapshot, and adding a new test case. The core logic change is in isDefaultPreset function to ensure compatibility. While the change fixes the issue for v1, it introduces a potential logic issue for newer versions. I've provided a suggestion to make the implementation more robust and consistent with Rsbuild's core logic across versions.
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in @rsbuild/plugin-vue where the splitChunks configuration was not working correctly with Rsbuild v1 due to an overly restrictive conditional check.
Changes:
- Simplified the
isDefaultPresetfunction logic insplitChunks.tsto remove an unnecessary empty object check that prevented the plugin from working with Rsbuild v1 - Added a test to verify splitChunks functionality with Rsbuild v1
- Added
@rsbuild/core-v1as a dev dependency for testing compatibility
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/plugin-vue/src/splitChunks.ts | Removed the overly restrictive check for empty splitChunks object, aligning with plugin-react's implementation |
| packages/plugin-vue/tests/index.test.ts | Added test case for Rsbuild v1 compatibility |
| packages/plugin-vue/tests/snapshots/index.test.ts.snap | Added snapshot for the new v1 test case |
| packages/plugin-vue/package.json | Added @rsbuild/core-v1 dev dependency |
| pnpm-lock.yaml | Updated lockfile to reflect new dev dependency |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Deploying rsbuild with
|
| Latest commit: |
fea6ba9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://84351ff0.rsbuild-v2.pages.dev |
| Branch Preview URL: | https://vue-split-chunks-0202.rsbuild-v2.pages.dev |
1 participant
Summary
Ensuring that the splitChunks configuration of
@rsbuild/plugin-vueworks as expected with Rsbuild 1.x.Checklist