docs: refine chunk splitting guide in optimize-bundle.mdx#7094
docs: refine chunk splitting guide in optimize-bundle.mdx#7094chenjiahan merged 1 commit intomainfrom
Conversation
Summary of ChangesHello @chenjiahan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Deploying rsbuild with
|
| Latest commit: |
d182f83
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://74c91fdd.rsbuild-v2.pages.dev |
| Branch Preview URL: | https://chunk-splitting-0131.rsbuild-v2.pages.dev |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refines the documentation for chunk splitting in optimize-bundle.mdx for both English and Chinese versions. The changes simplify the content by removing a code example for a deprecated feature and updating the text to refer to the new splitChunks configuration presets. My main feedback is to correct a likely typo in the URL anchor for the new link to ensure it works correctly. Overall, the changes improve the clarity and accuracy of the documentation.
There was a problem hiding this comment.
Pull request overview
This PR refines the chunk splitting documentation in optimize-bundle.mdx to align with the new splitChunks configuration introduced in Rsbuild 2.0 (PR #7073). The documentation is updated to remove references to the deprecated performance.chunkSplit API and point users to the new splitChunks.preset configuration.
Changes:
- Updated the chunk splitting section description to be more concise and clearer
- Removed the deprecated
performance.chunkSplitconfiguration example - Replaced with a reference to the new
/config/split-chunks#splitchunkspresetdocumentation
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| website/docs/en/guide/optimization/optimize-bundle.mdx | Updated English documentation to reference new splitChunks.preset configuration and removed deprecated example |
| website/docs/zh/guide/optimization/optimize-bundle.mdx | Updated Chinese documentation to reference new splitChunks.preset configuration and removed deprecated example |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 participant
Summary
Revised the description of chunk splitting in
optimize-bundle.mdxfor clearer guidance.Related Links
#7073
Checklist