fix(plugin-vue): skip chunk splitting for non-web targets#7091
fix(plugin-vue): skip chunk splitting for non-web targets#7091chenjiahan merged 1 commit intomainfrom
Conversation
Summary of ChangesHello @chenjiahan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the behavior of the Vue plugin by introducing a conditional check that restricts chunk splitting to web-specific build targets. This adjustment aims to optimize the build process by avoiding chunk splitting operations in environments where they are not applicable or beneficial, thereby improving efficiency and build performance for diverse project configurations. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request effectively addresses the stated goal of skipping chunk splitting for non-web targets by adding a clear condition to the applySplitChunksRule function. The change correctly destructures the config object from the environment and integrates the config.output.target !== 'web' check into the existing conditional logic. This ensures that the chunk splitting rule is only applied when the output target is specifically 'web' and the preset is default, aligning with the intended behavior.
There was a problem hiding this comment.
Pull request overview
Updates the Vue plugin’s splitChunks rule application to avoid injecting Vue-specific cacheGroups for non-web bundler targets.
Changes:
- Read
environment.configinto a localconfigvariable for reuse. - Skip applying the Vue splitChunks cacheGroups unless
output.target === 'web'.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3f65b362e1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const { config } = environment; | ||
| if (!isDefaultPreset(config) || config.output.target !== 'web') { | ||
| return; |
There was a problem hiding this comment.
This new guard skips the Vue/vendor cache groups whenever output.target is not exactly 'web', which means web-worker builds no longer get the splitChunks rules. Rsbuild treats web-worker as a web‑like target elsewhere (e.g., getBrowserslistByEnvironment in packages/core/src/createContext.ts checks target === 'web' || target === 'web-worker'), so dropping these cache groups for workers is a regression that can inflate worker bundle size and remove vendor caching. If the goal is only to avoid server/node targets, consider checking for config.output.target === 'node' or using utils.isServer instead of excluding web-worker.
Useful? React with 👍 / 👎.
1 participant
Summary
Updated the condition in Vue plugin to skip applying the split chunks rule unless
config.output.targetis'web'.Related Links
Checklist