fix(mf): remove unnecessary chunk split rules#7086
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Summary of ChangesHello @chenjiahan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the Module Federation plugin by removing a previously necessary workaround for chunk splitting conflicts. An upstream fix has rendered the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes a workaround related to chunk splitting rules for the Module Federation plugin, as the underlying issue has been fixed. This simplifies the code. The documentation in both English and Chinese has been updated to reflect this change. My main feedback is to ensure that the test snapshots are updated, as this change will likely affect them.
I am having trouble creating individual review comments. Click here to see my feedback.
packages/core/src/plugins/moduleFederation.ts (52-64)
With the removal of this workaround, the behavior of chunk splitting with module federation changes. The test snapshots in packages/core/tests/moduleFederation.test.ts will likely need to be updated to reflect this. Please run the tests and update the snapshots accordingly.
There was a problem hiding this comment.
Pull request overview
This PR removes an unnecessary workaround from the Module Federation plugin that was previously needed to prevent conflicts between the split-by-experience chunk splitting strategy and shared modules. The underlying issue has been fixed by implementing proper Module Federation support directly in the chunk splitting logic.
Changes:
- Removed workaround code from the MF plugin that was overriding
split-by-experiencestrategy tocustom - Updated English and Chinese documentation to remove references to this workaround behavior
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/core/src/plugins/moduleFederation.ts | Removed 16 lines of workaround code that converted split-by-experience to custom strategy when MF was used |
| website/docs/en/config/module-federation/options.mdx | Removed documentation line describing the removed workaround behavior |
| website/docs/zh/config/module-federation/options.mdx | Removed documentation line describing the removed workaround behavior (Chinese) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 participant
Summary
Remove unnecessary chunk split rules from the MF plugin, the related issue has been fixed.
Related Links
The same as https://github.com/module-federation/core/pull/3215/files#diff-5ee5efd88d835533c55cc15b806482c0b87c4c979df54ce195f0c32063cf43a5L77-L82
Checklist