fix: correctly read split size config#7076
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Summary of ChangesHello @chenjiahan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the chunk splitting logic within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates how splitBySize retrieves its configuration, switching from a userConfig property on the context to using config.performance.chunkSplit. This change aligns with the removal of userConfig. My review includes a suggestion to make the implementation more robust against potential runtime errors.
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
packages/core/src/plugins/splitChunks.ts:169
- The
split-by-sizestrategy lacks test coverage. While the fix correctly readsminSizeandmaxSizefromconfig.performance.chunkSplit, there are no tests verifying this behavior. Consider adding a test case similar to those inmoduleFederation.test.tsthat verify thesplit-by-sizestrategy works correctly with the legacyperformance.chunkSplitconfiguration.
function splitBySize(ctx: Context): SplitChunks {
const { override, forceSplittingGroups, config } = ctx;
const { minSize = 0, maxSize = Number.POSITIVE_INFINITY } = config.performance
.chunkSplit as SplitBySize;
return {
...getDefaultSplitChunks(config),
minSize,
maxSize,
...override,
cacheGroups: {
...forceSplittingGroups,
...override.cacheGroups,
},
};
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
chenjiahan
changed the title
chenjiahan
changed the title
1 participant
Summary
Updated
splitBySizeto readminSizeandmaxSizefromconfig.performance.chunkSplitinstead of the removeduserConfigproperty.Related Links
Checklist