feat(plugin-svelte): compatible with Rsbuild v1#7063
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Summary of ChangesHello @chenjiahan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the Svelte plugin by enabling it to function correctly across different versions of Rsbuild. It introduces a version detection mechanism to dynamically apply the appropriate JavaScript rule configurations, ensuring a consistent and reliable experience for users regardless of whether they are on Rsbuild v1 or v2. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Pull request overview
Updates @rsbuild/plugin-svelte to remain compatible with both Rsbuild v1 and v2 by detecting the major version at runtime and adjusting how it locates the “main JS rule” in the bundler chain.
Changes:
- Add Rsbuild v1 compatibility logic when accessing the JS rule / JS main rule in the plugin’s bundler-chain modification.
- Add a dedicated test case (and snapshots) that runs the plugin against Rsbuild v1 via an aliased devDependency.
- Add
@rsbuild/core-v1alias dependency for test/runtime validation in the plugin workspace.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Adds lock entries for the aliased @rsbuild/core-v1 dependency used by tests. |
| packages/plugin-svelte/package.json | Adds @rsbuild/core-v1 as a devDependency alias to test against Rsbuild v1. |
| packages/plugin-svelte/src/index.ts | Detects Rsbuild v1 and uses jsRule directly instead of jsRule.oneOfs.get(JS_MAIN). |
| packages/plugin-svelte/tests/index.test.ts | Adds a new test that runs the plugin using Rsbuild v1 (createRsbuildV1). |
| packages/plugin-svelte/tests/snapshots/index.test.ts.snap | Adds snapshots for the new Rsbuild v1 test expectations. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Svelte plugin to be compatible with Rsbuild v1 by adding a new dev dependency and adjusting the JS rules configuration. The changes also include adding a new test case and updating snapshots. I have identified a potential issue with the conditional logic for determining the JS rule and have provided a code suggestion to improve its clarity.
Deploying rsbuild with
|
| Latest commit: |
2fc8661
|
| Status: | 🚫 Deploy failed. |
1 participant
Summary
Updated the Svelte plugin to detect Rsbuild v1 and adjust how it configures JS rules, ensuring compatibility with both v1 and v2.
Related Links
Checklist