feat(plugin-less): compatible with Rsbuild v1 by chenjiahan · Pull Request #7054 · web-infra-dev/rsbuild

chenjiahan · 2026-01-26T13:22:33Z

Summary

Added support for Rsbuild v1 in @rsbuild/plugin-less by detecting the version and mapping rule IDs accordingly, ensuring that Less processing works seamlessly across Rsbuild v1 and v2.

Checklist

Tests updated (or not required).
Documentation updated (or not required).

gemini-code-assist · 2026-01-26T13:22:53Z

Summary of Changes

Hello @chenjiahan, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the @rsbuild/plugin-less by introducing backward compatibility with Rsbuild v1. The changes enable the plugin to adapt its internal logic for configuring Less processing rules based on the detected Rsbuild version, thereby broadening its usability without requiring separate plugin versions for different Rsbuild major releases. This ensures that projects migrating or maintaining both Rsbuild v1 and v2 can continue to use the Less plugin effectively.

Highlights

Rsbuild v1 Compatibility: The @rsbuild/plugin-less now supports Rsbuild v1 by dynamically detecting the Rsbuild version and mapping internal rule IDs accordingly, ensuring seamless Less processing across both v1 and v2.
Dynamic Rule ID Mapping: A new getRule helper function has been introduced in plugin-less to abstract the process of retrieving bundler chain rules, allowing for different rule ID structures between Rsbuild v1 and v2.
Dependency Updates: The @rsbuild/plugin-less package's peer dependency for @rsbuild/core has been updated to include ^1.3.0, and @rsbuild/core-v1 has been added as a dev dependency to facilitate testing of v1 compatibility.
Core Configuration Simplification: Less-specific CHAIN_ID entries (LESS_MAIN, LESS_RAW, LESS_INLINE) have been removed from packages/core/src/configChain.ts, as their handling is now managed dynamically within the plugin-less.
Test Coverage: New test cases and updated snapshots have been added to verify the correct behavior of the Less plugin when used with Rsbuild v1.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

The pull request successfully introduces compatibility for @rsbuild/plugin-less with Rsbuild v1. This is achieved through a new version detection mechanism and adaptive rule ID mapping within the plugin's core logic. The package.json updates correctly reflect the new peer dependency requirements, and a dedicated test case has been added to verify the v1 compatibility. The changes are well-aligned with the stated goal of the pull request.

packages/plugin-less/src/index.ts

packages/plugin-less/tests/index.test.ts

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d8288f4d1a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

packages/plugin-less/src/index.ts

cloudflare-workers-and-pages · 2026-01-26T13:29:39Z

Deploying rsbuild with Cloudflare Pages

Latest commit:	`681a340`
Status:	✅ Deploy successful!
Preview URL:	https://5ca38076.rsbuild-v2.pages.dev
Branch Preview URL:	https://plugin-less-0126.rsbuild-v2.pages.dev

View logs

Copilot

Pull request overview

Adds Rsbuild v1 compatibility to @rsbuild/plugin-less by branching on the Rsbuild core version and adjusting how Less/CSS rules are located and composed, plus adding a v1 test setup.

Changes:

Detect Rsbuild v1 vs v2 and map rule IDs accordingly when wiring Less rules/loaders.
Add a v1 test dependency (@rsbuild/core-v1) and a new v1 snapshot test.
Update snapshots and widen the plugin’s @rsbuild/core peer dependency minimum to ^1.3.0.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
pnpm-lock.yaml	Adds the `@rsbuild/core-v1` aliased dependency to support v1 testing.
packages/plugin-less/package.json	Adds `@rsbuild/core-v1` devDependency and adjusts `@rsbuild/core` peer range.
packages/plugin-less/src/index.ts	Introduces v1/v2 branching and new rule-id mapping logic for Less rules.
packages/plugin-less/tests/index.test.ts	Adds a v1-specific test using `@rsbuild/core-v1`.
packages/plugin-less/tests/snapshots/index.test.ts.snap	Updates snapshots to reflect the new rule structure and adds v1 snapshots.
packages/core/src/configChain.ts	Removes `CHAIN_ID.ONE_OF.LESS_*` constants from core’s exported identifiers.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

packages/plugin-less/src/index.ts

packages/plugin-less/tests/index.test.ts

packages/core/src/configChain.ts

packages/plugin-less/src/index.ts

feat(plugin-less): compatible with Rsbuild v1

d8288f4

Copilot AI review requested due to automatic review settings January 26, 2026 13:22

github-actions bot added the release: feature label Jan 26, 2026

Copilot started reviewing on behalf of chenjiahan January 26, 2026 13:22 View session

gemini-code-assist bot reviewed Jan 26, 2026

View reviewed changes

packages/plugin-less/src/index.ts Show resolved Hide resolved

packages/plugin-less/tests/index.test.ts Outdated Show resolved Hide resolved

fix

58bcd1a

chatgpt-codex-connector bot reviewed Jan 26, 2026

View reviewed changes

packages/plugin-less/src/index.ts Show resolved Hide resolved

fix

b4763ca

Copilot AI reviewed Jan 26, 2026

View reviewed changes

chenjiahan added 2 commits January 26, 2026 21:49

fix

4c12637

docs

681a340

chenjiahan merged commit 3334d82 into main Jan 26, 2026
6 checks passed

chenjiahan deleted the plugin_less_0126 branch January 26, 2026 13:57

chenjiahan mentioned this pull request Jan 27, 2026

release: minor release for plugins #7064

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

feat(plugin-less): compatible with Rsbuild v1#7054

feat(plugin-less): compatible with Rsbuild v1#7054
chenjiahan merged 5 commits intomainfrom
plugin_less_0126

chenjiahan commented Jan 26, 2026

Uh oh!

gemini-code-assist bot commented Jan 26, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

cloudflare-workers-and-pages bot commented Jan 26, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Comments

Conversation

chenjiahan commented Jan 26, 2026

Summary

Related Links

Checklist

Uh oh!

gemini-code-assist bot commented Jan 26, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

cloudflare-workers-and-pages bot commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying rsbuild with Cloudflare Pages

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

cloudflare-workers-and-pages bot commented Jan 26, 2026 •

edited

Loading