Revert "chore: update plugin versions to 2.0.0-alpha.2 and adjust peer deps"#7053
Revert "chore: update plugin versions to 2.0.0-alpha.2 and adjust peer deps"#7053chenjiahan merged 2 commits intomainfrom
Conversation
This reverts commit ed80ab6.
Summary of ChangesHello @chenjiahan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request reverts a previous set of changes that aimed to introduce a 2.0.0-alpha version for Rsbuild plugins and adjust their peer dependencies. The decision to revert was made after testing revealed that a new major release for plugins would create an unnecessary burden for users during installation and upgrades. Instead, the strategy is to maintain backward compatibility, allowing plugins to work seamlessly with both Rsbuild v1 and v2. This change simplifies the dependency management and upgrade path for users. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Pull request overview
This PR reverts the decision to release 2.0 versions of all Rsbuild plugins (PRs #7049 and #7051). Instead of requiring users to upgrade plugins separately, the plugins will remain on 1.x versions but support both Rsbuild v1 and v2 through updated peerDependencies.
Changes:
- Reverted plugin versions from
2.0.0-alpha.3to their respective 1.x versions - Updated all plugin
peerDependenciesto support both Rsbuild v1 and v2:"^1.0.0 || ^2.0.0-0" - Simplified documentation to show single installation commands without version specifiers
Reviewed changes
Copilot reviewed 33 out of 34 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/plugin-babel/package.json | Reverted version to 1.0.7 and updated peerDependencies |
| packages/plugin-less/package.json | Reverted version to 1.5.1 and updated peerDependencies |
| packages/plugin-preact/package.json | Reverted version to 1.7.1 and updated peerDependencies |
| packages/plugin-react/package.json | Reverted version to 1.4.3 and updated peerDependencies |
| packages/plugin-sass/package.json | Reverted version to 1.4.1 and updated peerDependencies |
| packages/plugin-solid/package.json | Reverted version to 1.0.7 and updated peerDependencies |
| packages/plugin-stylus/package.json | Reverted version to 1.2.1 and updated peerDependencies |
| packages/plugin-svelte/package.json | Reverted version to 1.0.12 and updated peerDependencies |
| packages/plugin-svgr/package.json | Reverted version to 1.2.4 and updated peerDependencies |
| packages/plugin-vue/package.json | Reverted version to 1.2.3 and updated peerDependencies |
| packages/create-rsbuild/package.json | Updated workspace dependencies for plugins |
| pnpm-lock.yaml | Updated workspace dependency specifiers for consistency |
| website/docs/en/plugins/list/*.mdx | Simplified installation instructions (10 files) |
| website/docs/zh/plugins/list/*.mdx | Simplified installation instructions (10 files) |
| website/docs/en/guide/upgrade/v1-to-v2.mdx | Removed plugin upgrade instructions |
| website/docs/zh/guide/upgrade/v1-to-v2.mdx | Removed plugin upgrade instructions |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request successfully reverts the plugin versions and adjusts peer dependencies to ensure compatibility with both Rsbuild v1 and v2. The changes align with the goal of reducing installation and upgrade burden for users, which is a positive outcome. The documentation updates accurately reflect these changes by simplifying installation instructions and removing the outdated upgrade guide sections for plugins. Overall, the changes are well-executed and consistent with the stated objective.
1 participant
Summary
This reverts #7049 and #7051.
After testing, I concluded that releasing 2.0 version of all plugins would not be a good idea, as it would increase the installation and upgrade burden for users. Instead, I've decided to keep the plugin compatible with both Rsbuild v1 and v2, rather than introducing a new major release.
Checklist