test: remove compatibility tests for Rsbuild < 1.3.0#7044
Conversation
Summary of ChangesHello @chenjiahan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on refining the test suite for the Less, Sass, and Stylus plugins by eliminating outdated compatibility checks. By removing tests specifically designed for Rsbuild versions prior to 1.3.0, the project's testing infrastructure becomes more streamlined and relevant to current supported versions, reducing maintenance overhead and improving clarity. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly removes compatibility tests for Rsbuild versions older than 1.3.0 from the Less, Sass, and Stylus plugins. The changes are straightforward, consisting of deleting the relevant test cases and cleaning up unused imports. This simplifies the test setup as intended. The code removal is clean and I see no issues with this change.
There was a problem hiding this comment.
Pull request overview
This PR simplifies the test setup for the Less, Sass, and Stylus plugins by removing compatibility tests for Rsbuild versions older than 1.3.0. The changes reduce test maintenance burden by eliminating tests that mock the behavior of deprecated Rsbuild versions.
Changes:
- Removed backward compatibility tests for Rsbuild < 1.3.0 from plugin-less, plugin-sass, and plugin-stylus
- Cleaned up unused
RsbuildPluginAPItype imports from test files
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/plugin-stylus/tests/index.test.ts | Removed compatibility test for Rsbuild < 1.3.0 and unused RsbuildPluginAPI import |
| packages/plugin-sass/tests/index.test.ts | Removed compatibility test for Rsbuild < 1.3.0 and unused RsbuildPluginAPI import |
| packages/plugin-less/tests/index.test.ts | Removed compatibility test for Rsbuild < 1.3.0 and unused RsbuildPluginAPI import |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 participant
Summary
Simplifies the test setup for the Less, Sass, and Stylus plugins by removing compatibility tests for Rsbuild versions older than 1.3.0.
Checklist