feat(core): add ignore option for public directory copy in server plugin by JSH-data · Pull Request #7023 · web-infra-dev/rsbuild

JSH-data · 2026-01-23T09:18:08Z

Summary

This PR provides an enhancement addressing issue #6337
It adds a new server. publicDir.ignore option that enables pattern-based exclusion of files from the public directory.

Checklist

Tests updated (or not required).
Documentation updated (or not required).

gemini-code-assist · 2026-01-23T09:18:26Z

Summary of Changes

Hello @JSH-data, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant enhancement to the server plugin by adding a new ignore option within the server.publicDir configuration. This feature allows developers to specify glob patterns for files that should be excluded when copying the public directory to the build output. This directly addresses issue #6337, providing greater control over the build process and ensuring only necessary assets are included in the final distribution.

Highlights

New ignore option: Introduced server.publicDir.ignore to allow pattern-based exclusion of files from the public directory during the build process.
Glob pattern support: The ignore option supports glob patterns, enabling flexible file exclusion based on specified criteria.
Enhanced public directory handling: The server plugin now incorporates this ignore logic, preventing unwanted files from being copied to the distribution directory.
E2E test coverage: A new end-to-end test has been added to verify the correct functionality of the ignore option, ensuring ignored files are not copied.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a new ignore option for the server.publicDir configuration, allowing users to exclude specific files or directories from being copied to the output directory based on glob patterns. The implementation correctly integrates tinyglobby for pattern matching and includes necessary type definitions and a comprehensive E2E test case. The changes are well-structured and address the reported issue effectively.

Copilot

Pull request overview

This PR adds a new ignore option to the server.publicDir configuration, enabling pattern-based exclusion of files when copying from the public directory. This addresses issue #6337 by providing users with fine-grained control over which public files should be excluded from the build output.

Changes:

Added ignore property to PublicDirOptions type accepting glob patterns
Implemented filtering logic using tinyglobby to skip matched files during copy operations
Added default empty array for ignore in config normalization
Created e2e test validating the ignore functionality

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
packages/core/src/types/config.ts	Adds optional `ignore` property to `PublicDirOptions` type definition
packages/core/src/plugins/server.ts	Implements filtering logic to exclude files matching ignore patterns during public directory copy
packages/core/src/defaultConfig.ts	Sets default empty array for `ignore` option in config normalization
e2e/cases/server/public-dir/publicDir.test.ts	Adds test case verifying files matching ignore patterns are excluded from build output

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

packages/core/src/plugins/server.ts

Co-authored-by: Copilot <[email protected]>

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

packages/core/src/plugins/server.ts

packages/core/src/defaultConfig.ts

JSH-data · 2026-01-23T16:37:11Z

@chenjiahan

Hello, could you please take a look at this PR? The CI does not seem to be working.

Thank you for your time!

chenjiahan · 2026-01-24T00:37:34Z

Thank you for your contribution! I will take a look

chenjiahan

LGTM 👍

By the way, I'm considering using CopyRspackPlugin to copy public files in Rsbuild v2, so I may change this option from ignore to globOptions.ignore in another PRs, see https://rspack.rs/plugins/rspack/copy-rspack-plugin#globoptions

github-actions bot added the release: feature label Jan 23, 2026

JSH-data marked this pull request as ready for review January 23, 2026 09:18

Copilot AI review requested due to automatic review settings January 23, 2026 09:18

JSH-data force-pushed the feature/6337/public-ignore-option branch from 481e2fe to 6eb2af9 Compare January 23, 2026 09:19

gemini-code-assist bot reviewed Jan 23, 2026

View reviewed changes

Copilot AI reviewed Jan 23, 2026

View reviewed changes

packages/core/src/plugins/server.ts Outdated Show resolved Hide resolved

packages/core/src/plugins/server.ts Outdated Show resolved Hide resolved

JSH-data added 2 commits January 24, 2026 01:18

feat(core): add ignore option for public directory copy in server plugin

27af07e

test: add test to ignore specific files when copying publicDir

37ac70b

JSH-data force-pushed the feature/6337/public-ignore-option branch from 6eb2af9 to 37ac70b Compare January 23, 2026 16:18

JSH-data and others added 2 commits January 24, 2026 01:21

fix: guard against undefined ignore option

97a9e33

Co-authored-by: Copilot <[email protected]>

fix: replace hardcoded path offset with path.relative

fbb0c4c

JSH-data requested a review from Copilot January 23, 2026 16:29

Copilot AI reviewed Jan 23, 2026

View reviewed changes

packages/core/src/plugins/server.ts Show resolved Hide resolved

packages/core/src/defaultConfig.ts Show resolved Hide resolved

test: fix snapshots

bae59ef

chenjiahan approved these changes Jan 24, 2026

View reviewed changes

chenjiahan enabled auto-merge (squash) January 24, 2026 00:46

chenjiahan merged commit 8a6b55d into web-infra-dev:main Jan 24, 2026
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

feat(core): add ignore option for public directory copy in server plugin#7023

feat(core): add ignore option for public directory copy in server plugin#7023
chenjiahan merged 5 commits intoweb-infra-dev:mainfrom
JSH-data:feature/6337/public-ignore-option

JSH-data commented Jan 23, 2026 •

edited

Loading

Uh oh!

gemini-code-assist bot commented Jan 23, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

JSH-data commented Jan 23, 2026

Uh oh!

chenjiahan commented Jan 24, 2026

Uh oh!

chenjiahan left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Comments

Conversation

JSH-data commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Related Links

Checklist

Uh oh!

gemini-code-assist bot commented Jan 23, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

JSH-data commented Jan 23, 2026

Uh oh!

chenjiahan commented Jan 24, 2026

Uh oh!

chenjiahan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

JSH-data commented Jan 23, 2026 •

edited

Loading