test(e2e): fix service worker flaky tests by stormslowly · Pull Request #7017 · web-infra-dev/rsbuild

stormslowly · 2026-01-23T03:10:10Z

Summary

Error: browserContext.waitForEvent: Test timeout of 30000ms exceeded.

  11 |   // Setup service worker in playwright
  12 |   const context = page.context();
> 13 |   const serviceWorkerPromise = context.waitForEvent('serviceworker');
     |                                        ^
  14 |   await page.reload();
  15 |   await serviceWorkerPromise;
  16 |   await page.evaluate(async () => {
    at waitForServiceWorker (/rsbuild/e2e/cases/workers/service-worker-environments/index.test.ts:13:40)

Use a stable and platform-independent way to determine service worker started or not
Add HTML reporter and artifact upload that for later review by playwright show-report <path to playwright-report>

Checklist

Tests updated (or not required).
Documentation updated (or not required).

gemini-code-assist · 2026-01-23T03:10:21Z

Summary of Changes

Hello @stormslowly, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the debugging and reporting capabilities for Playwright end-to-end tests. By enabling the HTML reporter, test results will be presented in a more visual and interactive format. Additionally, activating tracing will provide comprehensive logs of test execution, making it easier to identify and resolve issues.

Highlights

Playwright Reporter Configuration: The Playwright test runner configuration has been updated to include an HTML reporter in addition to the existing list reporter. This will generate interactive HTML reports for test runs.
Playwright Tracing: Tracing has been enabled for Playwright tests by setting trace: 'on' in the use configuration. This will capture detailed execution traces, aiding in debugging test failures.

Ignored Files

Ignored by pattern: .github/workflows/** (1)
- .github/workflows/test.yml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request enables the HTML reporter for Playwright tests and turns on tracing for all test runs. While enabling the HTML reporter is a good addition for better test reporting, enabling tracing for all tests with trace: 'on' can be inefficient. I've suggested a more optimal configuration for tracing that will only retain traces for failed tests, which should improve performance and reduce storage usage in your CI environment.

e2e/playwright.config.ts

cloudflare-workers-and-pages · 2026-01-23T03:12:19Z

Deploying rsbuild-v2 with Cloudflare Pages

Latest commit:	`786f12e`
Status:	✅ Deploy successful!
Preview URL:	https://172cb334.rsbuild-v2.pages.dev
Branch Preview URL:	https://chore-e2e-report.rsbuild-v2.pages.dev

View logs

Copilot

Pull request overview

Fixes flaky Playwright service worker E2E tests by switching from Playwright’s serviceworker event waiting to an in-page readiness signal, and adds CI artifacts for easier debugging of failures.

Changes:

Update the service worker E2E test to wait for SW readiness via navigator.serviceWorker/window.swStatus.
Enable Playwright HTML reporting and trace collection.
Upload Playwright report/results as CI artifacts for later inspection.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
e2e/playwright.config.ts	Adds HTML reporter and configures trace collection for debugging failures.
e2e/cases/workers/service-worker-environments/index.test.ts	Reworks SW readiness waiting logic to reduce flakiness.
.github/workflows/test.yml	Uploads Playwright HTML report and test results as CI artifacts.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

e2e/cases/workers/service-worker-environments/index.test.ts

e2e/playwright.config.ts

.github/workflows/test.yml

cloudflare-workers-and-pages · 2026-01-23T11:47:27Z

Deploying rsbuild with Cloudflare Pages

Latest commit:	`e0f23f6`
Status:	✅ Deploy successful!
Preview URL:	https://5afde219.rsbuild-v2.pages.dev
Branch Preview URL:	https://chore-e2e-report.rsbuild-v2.pages.dev

View logs

chenjiahan

LGTM

chenjiahan · 2026-01-23T13:07:48Z

E2E tracing performance:

default: 23.2s / 21.3s / 22.1s
trace: 'on': 24.6s / 26.5s / 26.5s
trace: 'retain-on-failure': 23.3s / 22.6s / 22.6s

stormslowly added 2 commits January 23, 2026 11:08

chore: enable html reporter

2958137

chore: upload artifact

21575b1

gemini-code-assist bot reviewed Jan 23, 2026

View reviewed changes

e2e/playwright.config.ts Outdated Show resolved Hide resolved

stormslowly added 2 commits January 23, 2026 11:45

chore: better CI performance

bdc13ed

fix: flaky service worker test case

36e5c8c

stormslowly changed the title ~~chore: enable html reporter~~ chore(test): fix service worker flaky tests Jan 23, 2026

stormslowly marked this pull request as ready for review January 23, 2026 05:58

Copilot AI review requested due to automatic review settings January 23, 2026 05:58

Copilot started reviewing on behalf of stormslowly January 23, 2026 05:58 View session

Copilot AI reviewed Jan 23, 2026

View reviewed changes

stormslowly requested a review from chenjiahan January 23, 2026 06:15

stormslowly added 2 commits January 23, 2026 14:27

refactor: fast fail in error happens

786f12e

refactor: trace retained only on failure

e0f23f6

chenjiahan approved these changes Jan 23, 2026

View reviewed changes

chenjiahan changed the title ~~chore(test): fix service worker flaky tests~~ test(e2e): fix service worker flaky tests Jan 23, 2026

chenjiahan merged commit f533ad3 into main Jan 23, 2026
7 checks passed

chenjiahan deleted the chore/e2e_report branch January 23, 2026 13:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

test(e2e): fix service worker flaky tests#7017

test(e2e): fix service worker flaky tests#7017
chenjiahan merged 6 commits intomainfrom
chore/e2e_report

stormslowly commented Jan 23, 2026 •

edited

Loading

Uh oh!

gemini-code-assist bot commented Jan 23, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

cloudflare-workers-and-pages bot commented Jan 23, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cloudflare-workers-and-pages bot commented Jan 23, 2026

Uh oh!

chenjiahan left a comment

Uh oh!

chenjiahan commented Jan 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Comments

Conversation

stormslowly commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Related Links

Checklist

Uh oh!

gemini-code-assist bot commented Jan 23, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

cloudflare-workers-and-pages bot commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying rsbuild-v2 with Cloudflare Pages

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cloudflare-workers-and-pages bot commented Jan 23, 2026

Deploying rsbuild with Cloudflare Pages

Uh oh!

chenjiahan left a comment

Choose a reason for hiding this comment

Uh oh!

chenjiahan commented Jan 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

stormslowly commented Jan 23, 2026 •

edited

Loading

cloudflare-workers-and-pages bot commented Jan 23, 2026 •

edited

Loading