test: reset logger level after each test#7015
Conversation
Summary of ChangesHello @chenjiahan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a cleanup step in the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Pull request overview
This PR adds cleanup logic to reset the global logger level after each test in the HMR log-level test suite, preventing test pollution from persisting logger state modifications.
Changes:
- Added
test.afterEachhook to reset logger level to 'info' after each test - Imported the
loggerfrom '@rsbuild/core' to enable the reset
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a test.afterEach hook to reset the logger level in e2e/cases/hmr/log-level/index.test.ts. This is a good practice to improve test isolation and prevent state from one test leaking into another. I've added one suggestion to make this reset logic more robust by saving and restoring the original logger level, rather than hardcoding it to 'info'. This will make the tests more resilient to different environments, such as when running in debug mode.
Deploying rsbuild-v2 with
|
| Latest commit: |
b9723f2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://13de3dca.rsbuild-v2.pages.dev |
| Branch Preview URL: | https://reset-log-level-0122.rsbuild-v2.pages.dev |
1 participant
Summary
Adds an
afterEachhook to resetlogger.levelto'info'after each test, ensuring logger state does not leak between tests.Checklist