test: simplify assertions in SSR tests#7013
Merged
chenjiahan merged 1 commit intomainfrom Jan 22, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies SSR-related test assertions by replacing direct response text checks with Playwright's page.locator('body').toContainText() matcher, making the tests more aligned with typical Playwright testing patterns.
Changes:
- Updated SSR test assertions in
e2e/cases/server/ssr/index.test.tsto usepage.locator('body').toContainText()instead of checking response text with regex - Updated custom server test assertions in
e2e/cases/server/custom-server/index.test.tsusing the same approach
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| e2e/cases/server/ssr/index.test.ts | Replaced 5 instances of res?.text().toMatch(/Rsbuild with React/) with page.locator('body').toContainText('Rsbuild with React') across multiple SSR test cases |
| e2e/cases/server/custom-server/index.test.ts | Replaced 2 instances of res?.text().toBe('Hello polka!') with page.locator('body').toContainText('Hello polka!') in custom server tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
page.locator('body')withtoContainTextfor verifying the presence of "Rsbuild with React" instead of checking the response text directly.Related Links
Checklist