test: update SSR test to use retried backend assert#7011
Conversation
Summary of ChangesHello @stormslowly, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines an existing end-to-end test by migrating its content assertion logic to leverage Playwright's more robust and retried assertion capabilities. The change aims to improve test stability and reliability by ensuring the test waits for the expected content to be present in the DOM before evaluating the assertion. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors an end-to-end test to use Playwright's web-first, auto-retrying assertions. The change from expect(await res?.text()).toMatch(...) to await expect(page.locator(...)).toContainText(...) is a great improvement, making the test more robust and less susceptible to flakiness from timing issues. I have added one suggestion to use a more specific locator to further improve the test's precision and resilience.
Deploying rsbuild-v2 with
|
| Latest commit: |
d41e4ba
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3b70a0c4.rsbuild-v2.pages.dev |
| Branch Preview URL: | https://fix-flaky-test.rsbuild-v2.pages.dev |
chenjiahan
changed the title
There was a problem hiding this comment.
Pull request overview
This PR updates the SSR ESM test (ssr-type-module) to use Playwright's recommended assertion pattern with built-in auto-retry functionality instead of manually checking the response text.
Changes:
- Replaces
res?.text()assertion withpage.locator()+toContainText()for better reliability and auto-retry behavior
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2 participants
Summary
Updates the SSR ESM test to use Playwright's recommended assertion style.
Checklist