chore: remove Netlify configuration and add redirects file#7004
chore: remove Netlify configuration and add redirects file#7004chenjiahan merged 4 commits intomainfrom
Conversation
✅ Deploy Preview for rsbuild-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary of ChangesHello @chenjiahan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request completes the migration of the project's website hosting from Netlify to Cloudflare Pages. The primary goal was to adapt the existing redirect logic to the new platform's requirements and to update documentation to reflect this change, ensuring a smooth transition and accurate project information. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Deploying rsbuild-v2 with
|
| Latest commit: |
4dfc242
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3e8f7ef6.rsbuild-v2.pages.dev |
| Branch Preview URL: | https://migrate-site-0121.rsbuild-v2.pages.dev |
There was a problem hiding this comment.
Code Review
This pull request migrates the project from Netlify to Cloudflare Pages. The changes include removing the Netlify configuration, adding a _redirects file for Cloudflare, and updating README files to remove references to Netlify. The changes are generally good, but I've identified an issue in the new _redirects file where a Netlify-specific syntax is used, which could cause problems on Cloudflare Pages. I've included a suggestion to correct this.
There was a problem hiding this comment.
Pull request overview
This PR migrates the rsbuild.rs documentation website from Netlify to Cloudflare Pages by updating configuration files and removing obsolete references.
Changes:
- Removed Netlify configuration file (
netlify.toml) and replaced it with Cloudflare Pages-compatible_redirectsfile - Removed Netlify-specific sections from all README files (English, Chinese, Portuguese)
- Cleaned up references to Netlify-hosted Web Infra QoS dashboard
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| website/docs/public/netlify.toml | Deleted Netlify-specific configuration file |
| website/docs/public/_redirects | Added Cloudflare Pages redirect rules with proper syntax conversion |
| README.md | Removed Quality section and Netlify hosting credits |
| README.zh-CN.md | Removed Quality section and Netlify hosting credits (Chinese) |
| README.pt-BR.md | Removed Quality section and Netlify hosting credits (Portuguese) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This reverts commit 1b8f623.
Summary
rsbuild.rshas been migrated to Cloudflare Pages.netlify.tomlto a new_redirectsfileChecklist