test(e2e): enable skipped tests for Preact#7001
Conversation
✅ Deploy Preview for rsbuild-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary of ChangesHello @chenjiahan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on improving the stability and coverage of Preact-related features by re-enabling several end-to-end tests that were previously skipped. This change ensures that core functionalities like basic component rendering and Hot Module Replacement (HMR) for Preact are actively tested. Concurrently, a minor version update to the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request successfully re-enables several previously skipped E2E tests for Preact components and updates the @rspack/plugin-preact-refresh dependency to version 1.1.5. These changes indicate that the underlying issues preventing these tests from passing have been resolved, which is a positive step for the project's stability and test coverage. The dependency update is also reflected correctly in the lockfile. Overall, the changes are well-aligned with the pull request's summary and contribute to improving the Preact integration.
There was a problem hiding this comment.
Pull request overview
This PR re-enables previously skipped E2E tests for Preact by updating the @rspack/plugin-preact-refresh dependency from version 1.1.4 to 1.1.5, which presumably fixes the issues that caused the tests to be skipped.
Changes:
- Updated
@rspack/plugin-preact-refreshfrom1.1.4to1.1.5in package.json and pnpm-lock.yaml - Re-enabled three E2E tests that were previously skipped: basic Preact component rendering, HMR functionality, and HMR with createContext
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/plugin-preact/package.json | Updates the dependency version specifier for @rspack/plugin-preact-refresh from ^1.1.4 to ^1.1.5 |
| pnpm-lock.yaml | Updates lockfile entries to reflect the new version 1.1.5 of @rspack/plugin-preact-refresh |
| e2e/cases/plugin-preact/basic/index.test.ts | Removes test.skip() wrapper to re-enable the basic Preact component rendering test |
| e2e/cases/plugin-preact/prefresh/index.test.ts | Removes test.skip() wrapper to re-enable the HMR test |
| e2e/cases/plugin-preact/prefresh-context/index.test.ts | Removes test.skip() wrapper to re-enable the HMR with createContext test |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 participant
Summary
@rspack/plugin-preact-refreshfrom version1.1.4to1.1.5Checklist