feat(deps)!: update @rspack/core to v2 canary#6988
Conversation
✅ Deploy Preview for rsbuild-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary of ChangesHello @chenjiahan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on upgrading the project's core bundling dependency, Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the @rspack/core dependency to a v2 canary version and addresses the associated breaking changes. The modifications to package.json files are appropriate for this update, including the addition of new dependencies like @module-federation/runtime-tools. The refactoring in packages/core/src/plugins/cache.ts correctly adapts to the new cache configuration API in Rspack, which simplifies the code. The changes appear solid and align with the PR's objective.
There was a problem hiding this comment.
Pull request overview
This PR updates the @rspack/core dependency from v1.7.2 to v2.0.0-canary-20260116 (a pre-release version) and handles the associated breaking changes in the cache API.
Changes:
- Updated @rspack/core to v2 canary version with updated Node.js requirements
- Migrated cache configuration from
experiments.cacheto top-levelcacheAPI - Added necessary peer dependencies for module federation and workspace development
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/core/package.json | Updated @rspack/core dependency to v2 canary version |
| packages/core/src/plugins/cache.ts | Migrated cache configuration API from experiments.cache to top-level cache object |
| package.json | Added browserslist-load-config and watchpack as root devDependencies |
| e2e/package.json | Added @module-federation/runtime-tools dependency for v2 peer requirement |
| pnpm-lock.yaml | Updated all rspack bindings and transitive dependencies to v2 canary |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 participant
Summary
@rspack/coreto v2 canary and handle breaking changes.Related Links
Checklist