fix: correct 'drafts' in lightningcss minimize plugin#6987
Conversation
✅ Deploy Preview for rsbuild-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary of ChangesHello @chenjiahan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a minor but critical configuration error within the 'lightningcss minimize plugin'. By correcting a typo in a property name, it ensures that the 'drafts' option from 'loaderOptions' is accurately recognized and applied, leading to more reliable and correct CSS minimization processes. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses a bug in the lightningcss minimize plugin by correcting a property name from draft to drafts. This change ensures that the configuration options for handling CSS drafts are correctly passed during the minification process. The fix is straightforward and appears correct. I have no further comments or suggestions.
There was a problem hiding this comment.
Pull request overview
This PR fixes a typo in the lightningcss minimize plugin configuration by correcting the property name from 'draft' to 'drafts' when picking options from loaderOptions.
Changes:
- Corrected property name typo from
'draft'to'drafts'in thepick()call for lightningcss minimizer options
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 participant
Summary
Corrects the property name from
drafttodraftswhen picking lightningcss options fromloaderOptions.Related Links
Checklist