Conversation
✅ Deploy Preview for rsbuild-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR updates the TransformImport type definition to use stricter typing for customName and customStyleName properties (changing from any to string), reorders these properties for better readability, and adds two new optional fields: ignoreEsComponent and ignoreStyleComponent (both of type string[]). The changes also include updating references from "webpack" to "Rspack" in various comments to reflect the project's current bundler focus.
Changes:
- Updated
TransformImporttype to use stricter types (stringinstead ofany) forcustomNameandcustomStyleName - Added new optional properties
ignoreEsComponentandignoreStyleComponentto theTransformImporttype - Updated comments to reference "Rspack" instead of "webpack" for accuracy
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/core/src/types/config.ts | Updated TransformImport type definition with stricter types and new properties |
| website/docs/zh/config/source/transform-import.mdx | Updated Chinese documentation to reflect type changes |
| website/docs/en/config/source/transform-import.mdx | Updated English documentation to reflect type changes |
| scripts/test-helper/src/index.ts | Updated comment to reference "Rspack" instead of "rspack/webpack" |
| packages/core/src/plugins/splitChunks.ts | Updated comments to reference "Rspack" instead of "webpack" |
| packages/core/src/plugins/html.ts | Removed unnecessary type annotation comment and simplified code |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 participant
Summary
Updated the
TransformImporttype to use stricter types forcustomNameandcustomStyleName, and added new optionsignoreEsComponentandignoreStyleComponentRelated Links
Checklist