fix: update type definitions for source.define#6985
Conversation
Summary of ChangesHello @chenjiahan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the type definitions for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
✅ Deploy Preview for rsbuild-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This is a solid pull request that improves type safety and fixes a potential bug. By replacing the custom Define type with Rspack.DefinePluginOptions, the configuration is now more consistent with the underlying Rspack bundler. The update from typeof value === 'object' to isPlainObject(value) is a great catch, preventing a potential runtime error when process.env is defined as null. The documentation changes are also accurate and helpful. Overall, these are excellent changes.
There was a problem hiding this comment.
Pull request overview
This PR updates the type definitions for source.define to use DefinePluginOptions from @rspack/core instead of a custom Define type, improving type safety and consistency with Rspack.
Changes:
- Replaced custom
Definetype with Rspack'sDefinePluginOptionstype - Updated import statements to include
DefinePluginOptionsandisPlainObjecthelper - Modified type narrowing logic in the
checkProcessEnvSecurityfunction - Updated documentation to reflect the new type
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/core/src/types/config.ts | Removed custom Define type and replaced references with DefinePluginOptions |
| packages/core/src/plugins/define.ts | Updated imports and improved type safety using isPlainObject helper |
| website/docs/en/config/source/define.mdx | Updated type documentation from Record<string, unknown> to Record<string, CodeValue> |
| website/docs/zh/config/source/define.mdx | Updated type documentation from Record<string, unknown> to Record<string, CodeValue> |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 participant
Summary
Replaced the custom
Definetype withRspack.DefinePluginOptionsto provide better type safety and consistency with Rspack.Checklist