Skip to content

Comments

fix: remove unused CHAIN_ID entries#6980

Merged
chenjiahan merged 1 commit intomainfrom
clean_chain_id_0115
Jan 16, 2026
Merged

fix: remove unused CHAIN_ID entries#6980
chenjiahan merged 1 commit intomainfrom
clean_chain_id_0115

Conversation

@chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Jan 15, 2026

Summary

Updates the CHAIN_ID constants, clean up unused identifiers and update plugin naming.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings January 15, 2026 14:31
@netlify
Copy link

netlify bot commented Jan 15, 2026

Deploy Preview for rsbuild-v2 ready!

Name Link
🔨 Latest commit 37508ea
🔍 Latest deploy log https://app.netlify.com/projects/rsbuild-v2/deploys/6968fa4d08cdce000806d651
😎 Deploy Preview https://deploy-preview-6980--rsbuild-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @chenjiahan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the CHAIN_ID constants by removing obsolete entries and updating naming conventions. The changes aim to improve code cleanliness and consistency by eliminating unused identifiers like CSS_MODULES_TS and TS_CONFIG_PATHS, and aligning the MANIFEST plugin name with Rspack.

Highlights

  • Unused CHAIN_ID Removal: Removed the CSS_MODULES_TS entry from the CHAIN_ID constant, as it was no longer in use.
  • Plugin Naming Update: Updated the MANIFEST entry within CHAIN_ID from webpack-manifest to rspack-manifest for consistency with Rspack.
  • Resolve Plugin Cleanup: Eliminated the RESOLVE_PLUGIN.TS_CONFIG_PATHS entry, which was an unused predefined resolve plugin.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the CHAIN_ID constants by removing unused entries and renaming one for better consistency. The changes are straightforward and improve the maintainability of the configuration constants. I've reviewed the code and have no issues to report.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR cleans up the CHAIN_ID constants by removing unused entries and updating plugin documentation to reflect the current Rspack ecosystem.

Changes:

  • Removed unused CSS_MODULES_TS loader identifier from CHAIN_ID.USE
  • Removed unused RESOLVE_PLUGIN section and its TS_CONFIG_PATHS identifier
  • Updated comment for MANIFEST plugin from "WebpackManifestPlugin" to "RspackManifestPlugin" to reflect the actual plugin being used

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chenjiahan chenjiahan merged commit d8204bb into main Jan 16, 2026
17 checks passed
@chenjiahan chenjiahan deleted the clean_chain_id_0115 branch January 16, 2026 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant