fix(create-rsbuild): update @rsbuild/core dependency to v2.0.0-0#6978
fix(create-rsbuild): update @rsbuild/core dependency to v2.0.0-0#6978chenjiahan merged 1 commit intomainfrom
Conversation
✅ Deploy Preview for rsbuild-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary of ChangesHello @chenjiahan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on synchronizing the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly updates the @rsbuild/core dependency to ^2.0.0-0 across all project templates. The changes are consistent and reflect the intention to adopt the new major version.
While the main dependency is updated, I've noticed that the associated @rsbuild plugins in the templates are not using their latest patch versions. To ensure consistency and include the latest fixes, it would be beneficial to update them as well.
Here are the suggested updates for the plugin versions in the devDependencies of the respective package.json files:
@rsbuild/plugin-preact:^1.7.0->^1.7.1(intemplate-preact-jsandtemplate-preact-ts)@rsbuild/plugin-react:^1.4.2->^1.4.3(intemplate-react-js,template-react-ts,template-react18-js,template-react18-ts)@rsbuild/plugin-babel:^1.0.6->^1.0.7(intemplate-solid-jsandtemplate-solid-ts)@rsbuild/plugin-solid:^1.0.6->^1.0.7(intemplate-solid-jsandtemplate-solid-ts)@rsbuild/plugin-svelte:^1.0.11->^1.0.12(intemplate-svelte-jsandtemplate-svelte-ts)@rsbuild/plugin-vue:^1.2.2->^1.2.3(intemplate-vue3-jsandtemplate-vue3-ts)
Additionally, please check if @rsbuild/plugin-vue2 in the Vue 2 templates has a newer patch version and update it accordingly.
Aligning these versions would improve the overall quality and maintainability of the templates.
There was a problem hiding this comment.
Pull request overview
This PR updates the @rsbuild/core dependency from ^1.7.2 to ^2.0.0-0 across all project templates in the create-rsbuild package. This represents a major version upgrade to a pre-release version (alpha) of Rsbuild v2.
Changes:
- Updated
@rsbuild/coredependency to^2.0.0-0across all 18 template variants - The update spans templates for 9 different frameworks (React 18, React 19, Vue 2, Vue 3, Solid, Svelte, Preact, Lit, and Vanilla)
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 14 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/create-rsbuild/template-vue3-ts/package.json | Updated @rsbuild/core to v2.0.0-0 for Vue 3 TypeScript template |
| packages/create-rsbuild/template-vue3-js/package.json | Updated @rsbuild/core to v2.0.0-0 for Vue 3 JavaScript template |
| packages/create-rsbuild/template-vue2-ts/package.json | Updated @rsbuild/core to v2.0.0-0 for Vue 2 TypeScript template |
| packages/create-rsbuild/template-vue2-js/package.json | Updated @rsbuild/core to v2.0.0-0 for Vue 2 JavaScript template |
| packages/create-rsbuild/template-vanilla-ts/package.json | Updated @rsbuild/core to v2.0.0-0 for Vanilla TypeScript template |
| packages/create-rsbuild/template-vanilla-js/package.json | Updated @rsbuild/core to v2.0.0-0 for Vanilla JavaScript template |
| packages/create-rsbuild/template-svelte-ts/package.json | Updated @rsbuild/core to v2.0.0-0 for Svelte TypeScript template |
| packages/create-rsbuild/template-svelte-js/package.json | Updated @rsbuild/core to v2.0.0-0 for Svelte JavaScript template |
| packages/create-rsbuild/template-solid-ts/package.json | Updated @rsbuild/core to v2.0.0-0 for Solid TypeScript template |
| packages/create-rsbuild/template-solid-js/package.json | Updated @rsbuild/core to v2.0.0-0 for Solid JavaScript template |
| packages/create-rsbuild/template-react18-ts/package.json | Updated @rsbuild/core to v2.0.0-0 for React 18 TypeScript template |
| packages/create-rsbuild/template-react18-js/package.json | Updated @rsbuild/core to v2.0.0-0 for React 18 JavaScript template |
| packages/create-rsbuild/template-react-ts/package.json | Updated @rsbuild/core to v2.0.0-0 for React (19) TypeScript template |
| packages/create-rsbuild/template-react-js/package.json | Updated @rsbuild/core to v2.0.0-0 for React (19) JavaScript template |
| packages/create-rsbuild/template-preact-ts/package.json | Updated @rsbuild/core to v2.0.0-0 for Preact TypeScript template |
| packages/create-rsbuild/template-preact-js/package.json | Updated @rsbuild/core to v2.0.0-0 for Preact JavaScript template |
| packages/create-rsbuild/template-lit-ts/package.json | Updated @rsbuild/core to v2.0.0-0 for Lit TypeScript template |
| packages/create-rsbuild/template-lit-js/package.json | Updated @rsbuild/core to v2.0.0-0 for Lit JavaScript template |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "devDependencies": { | ||
| "@rsbuild/core": "^1.7.2", | ||
| "@rsbuild/core": "^2.0.0-0", | ||
| "@rsbuild/plugin-vue": "^1.2.2", |
There was a problem hiding this comment.
The @rsbuild/core dependency is being updated to v2.0.0-0 (a major version pre-release), but @rsbuild/plugin-vue remains at v1.2.2. A major version bump in the core package typically includes breaking changes that may require corresponding updates to plugins. Please verify that @rsbuild/plugin-vue v1.2.2 is compatible with @rsbuild/core v2.0.0-0, or update the plugin version accordingly.
| "@rsbuild/plugin-vue": "^1.2.2", | |
| "@rsbuild/plugin-vue": "^2.0.0-0", |
| "devDependencies": { | ||
| "@rsbuild/core": "^1.7.2", | ||
| "@rsbuild/core": "^2.0.0-0", | ||
| "@rsbuild/plugin-svelte": "^1.0.11", |
There was a problem hiding this comment.
The @rsbuild/core dependency is being updated to v2.0.0-0 (a major version pre-release), but @rsbuild/plugin-svelte remains at v1.0.11. A major version bump in the core package typically includes breaking changes that may require corresponding updates to plugins. Please verify that @rsbuild/plugin-svelte v1.0.11 is compatible with @rsbuild/core v2.0.0-0, or update the plugin version accordingly.
| "@rsbuild/plugin-svelte": "^1.0.11", | |
| "@rsbuild/plugin-svelte": "^2.0.0-0", |
| "@rsbuild/plugin-babel": "^1.0.6", | ||
| "@rsbuild/plugin-solid": "^1.0.6", |
There was a problem hiding this comment.
The @rsbuild/core dependency is being updated to v2.0.0-0 (a major version pre-release), but @rsbuild/plugin-babel and @rsbuild/plugin-solid remain at v1.0.6. A major version bump in the core package typically includes breaking changes that may require corresponding updates to plugins. Please verify that these plugin versions are compatible with @rsbuild/core v2.0.0-0, or update the plugin versions accordingly.
| "@rsbuild/plugin-babel": "^1.0.6", | |
| "@rsbuild/plugin-solid": "^1.0.6", | |
| "@rsbuild/plugin-babel": "^2.0.0-0", | |
| "@rsbuild/plugin-solid": "^2.0.0-0", |
| "@rsbuild/plugin-babel": "^1.0.6", | ||
| "@rsbuild/plugin-solid": "^1.0.6" |
There was a problem hiding this comment.
The @rsbuild/core dependency is being updated to v2.0.0-0 (a major version pre-release), but @rsbuild/plugin-babel and @rsbuild/plugin-solid remain at v1.0.6. A major version bump in the core package typically includes breaking changes that may require corresponding updates to plugins. Please verify that these plugin versions are compatible with @rsbuild/core v2.0.0-0, or update the plugin versions accordingly.
| "@rsbuild/plugin-babel": "^1.0.6", | |
| "@rsbuild/plugin-solid": "^1.0.6" | |
| "@rsbuild/plugin-babel": "^2.0.0-0", | |
| "@rsbuild/plugin-solid": "^2.0.0-0" |
Summary
Updates the
@rsbuild/coreversion from^1.7.2to^2.0.0-0across all templates in thecreate-rsbuild.Related Links
Checklist