fix(create-rsbuild): remove unused fields from Rstest templates#6933
fix(create-rsbuild): remove unused fields from Rstest templates#6933chenjiahan merged 1 commit intov1.xfrom
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary of ChangesHello @chenjiahan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on refining the Rstest templates by eliminating unnecessary fields from their Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes unused name, private, and version fields from the package.json files in the Rstest templates. This is a good cleanup that improves the maintainability of the templates by removing redundant information. The changes are correct and consistently applied across all relevant files.
There was a problem hiding this comment.
Pull request overview
This PR removes redundant fields (name, private, and version) from the package.json files in all Rstest template directories. These fields are unnecessary because the rstest templates are merged into base templates during project creation.
- Removes duplicate metadata fields from 6 rstest template package.json files
- Streamlines template merging by eliminating redundant fields that already exist in base templates
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/create-rsbuild/template-rstest/vue-ts/package.json | Removes name, private, and version fields from Vue TypeScript rstest template |
| packages/create-rsbuild/template-rstest/vue-js/package.json | Removes name, private, and version fields from Vue JavaScript rstest template |
| packages/create-rsbuild/template-rstest/vanilla-ts/package.json | Removes name, private, and version fields from Vanilla TypeScript rstest template |
| packages/create-rsbuild/template-rstest/vanilla-js/package.json | Removes name, private, and version fields from Vanilla JavaScript rstest template |
| packages/create-rsbuild/template-rstest/react-ts/package.json | Removes name, private, and version fields from React TypeScript rstest template |
| packages/create-rsbuild/template-rstest/react-js/package.json | Removes name, private, and version fields from React JavaScript rstest template |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 participant
Summary
Removes the unused fields (
name,private, andversion) from thepackage.jsonfiles in all Rstest templates.Checklist