Skip to content

Comments

fix(builder)!: align postcss object behavior with Rsbuild#8310

Merged
chenjiahan merged 4 commits intomainfrom
postcss
Feb 5, 2026
Merged

fix(builder)!: align postcss object behavior with Rsbuild#8310
chenjiahan merged 4 commits intomainfrom
postcss

Conversation

@9aoy
Copy link
Contributor

@9aoy 9aoy commented Feb 4, 2026

Summary

Align postcss object behavior with Rsbuild, make postcss object override instead of merge.

The postcss object handling in Modern.js is currently inconsistent with Rsbuild:

  • Rsbuild applies override semantics
  • Modern.js applies merge semantics

This divergence was accidentally introduced during the upgrade to Rsbuild 1.x. 58f2868#diff-a86e848c67b89f2f9412c8fee114477c0ed805a5607500d47ddcebd5429595a5R67-R70
To maintain the previous behavior, several compatibility patches were later added in uni-builder, which increased complexity and maintenance cost.

This PR aligns Modern.js with Rsbuild by updating the postcss object behavior to use override semantics, matching Rsbuild’s configuration model.

Related Links

https://rsbuild.rs/config/tools/postcss#object-type

Checklist

  • I have added changeset via pnpm run change.
  • I have updated the documentation.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Feb 4, 2026

🦋 Changeset detected

Latest commit: 9f5c92a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 110 packages
Name Type
@modern-js/builder Patch
@modern-js/plugin-bff Patch
@modern-js/server Patch
@modern-js/app-tools Patch
@modern-js/plugin Patch
rsc-ssr-app Patch
bff-api-app Patch
bff-client-app Patch
bff-indep-client-app Patch
bff-hono Patch
deploy-server Patch
pure-esm-project Patch
@modern-js/plugin-ssg Patch
@modern-js/plugin-styled-components Patch
@modern-js/plugin-i18n Patch
@modern-js/image Patch
@modern-js/runtime Patch
@modern-js/plugin-polyfill Patch
@integration-test/alias-set Patch
app-document Patch
async-entry-test Patch
tmp Patch
integration-clean-dist-path Patch
integration-compatibility Patch
integration-custom-dist-path Patch
custom-file-system-entry Patch
integration-custom-template Patch
deploy Patch
dev-server Patch
integration-disable-html Patch
entries-app-builder Patch
app-custom-entries Patch
app-custom-routes-runtime Patch
app-custom Patch
app-entry Patch
app-route Patch
app-entry-server Patch
i18n-app-csr-html-lang Patch
i18n-app Patch
i18n-app-ssr-html-lang Patch
i18n-app-ssr Patch
i18n-custom-i18n-wrapper Patch
i18n-mf-app-provider Patch
i18n-mf-component-provider Patch
i18n-mf-consumer Patch
i18n-routes Patch
i18n-routes-ssr Patch
@integration-test/image-component Patch
main-entry-name Patch
nonce Patch
routes-match Patch
routes Patch
app-rsbuild-hooks Patch
rsc-csr-app Patch
rsc-csr-routes Patch
rsc-ssr-routes Patch
runtime-custom-plugin Patch
runtime-custom-config-plugin Patch
select-mul-entry-test Patch
select-one-entry-test Patch
server-config Patch
server-json-script Patch
server-monitors Patch
server-prod Patch
server-routes Patch
@source-code-build/app Patch
ssg-fixtures-mega-list-routes Patch
ssg-fixtures-nested-routes Patch
ssg-fixtures-simple Patch
ssg-fixtures-web-server Patch
ssr-base-async-entry-test Patch
ssr-base-json-test Patch
ssr-base-test Patch
ssr-base-fallback-test Patch
init Patch
ssr-base-loadable Patch
ssr-partial-test Patch
ssr-script-loading Patch
ssr-streaming-inline-test Patch
ssr-streaming-test Patch
styled-components-stream Patch
styled-components-string Patch
integration-tailwindcss-v2 Patch
integration-tailwindcss-v3 Patch
integration-tailwindcss-v4 Patch
tmp-dir Patch
write-to-dist Patch
@modern-js/bundle-diff-benchmark Patch
@modern-js/main-doc Patch
@modern-js/tsconfig Patch
@modern-js/flight-server-transform-plugin Patch
@modern-js/plugin-data-loader Patch
@modern-js/render Patch
@modern-js/bff-core Patch
@modern-js/bff-runtime Patch
@modern-js/server-core Patch
@modern-js/create-request Patch
@modern-js/prod-server Patch
@modern-js/server-runtime Patch
@modern-js/server-utils Patch
@modern-js/create Patch
@modern-js/i18n-utils Patch
@modern-js/runtime-utils Patch
@modern-js/sandpack-react Patch
@modern-js/types Patch
@modern-js/utils Patch
@modern-js/rslib Patch
@scripts/prebundle Patch
@scripts/rstest-config Patch
@scripts/release-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Feb 4, 2026

Deploy Preview for modernjs-v3 ready!

Name Link
🔨 Latest commit 9f5c92a
🔍 Latest deploy log https://app.netlify.com/projects/modernjs-v3/deploys/698410cca6b8040008dd9a2b
😎 Deploy Preview https://deploy-preview-8310--modernjs-v3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

Rsdoctor Bundle Diff Analysis

📊 Quick Summary
Project Total Size Change
bundle-diff 2.9 MB 0

Generated by Rsdoctor GitHub Action

@chenjiahan chenjiahan merged commit 7a278a6 into main Feb 5, 2026
10 checks passed
@chenjiahan chenjiahan deleted the postcss branch February 5, 2026 03:48
@caohuilin caohuilin mentioned this pull request Feb 5, 2026
@9aoy 9aoy mentioned this pull request Feb 10, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants