Skip to content

Make use of faster preset and multithreaded minimap2#26

Merged
wdecoster merged 2 commits into
wdecoster:masterfrom
Ge0rges:master
Mar 17, 2024
Merged

Make use of faster preset and multithreaded minimap2#26
wdecoster merged 2 commits into
wdecoster:masterfrom
Ge0rges:master

Conversation

@Ge0rges

@Ge0rges Ge0rges commented Mar 16, 2024

Copy link
Copy Markdown
Contributor

Switched to using the new version of minimap2 which has the new LrHq preset and multithreading.

Make use of that 4x faster preset.
Implement multithreading (I think it works?) for #18

@wdecoster

Copy link
Copy Markdown
Owner

Thank you @Ge0rges! Looks mostly okay, but the automated test reported two errors. Could you take a look at it? If necessary, I can help :)

@Ge0rges

Ge0rges commented Mar 17, 2024

Copy link
Copy Markdown
Contributor Author

Checking it out right now

@Ge0rges

Ge0rges commented Mar 17, 2024

Copy link
Copy Markdown
Contributor Author

@wdecoster should work now, I forgot to update the test functions.

@wdecoster

Copy link
Copy Markdown
Owner

@wdecoster
wdecoster merged commit c64acad into wdecoster:master Mar 17, 2024
@Ge0rges

Ge0rges commented Mar 17, 2024

Copy link
Copy Markdown
Contributor Author

Yeah I wasn't sure what that was about so I decided to leave it be for now.

@Ge0rges

Ge0rges commented Mar 17, 2024

Copy link
Copy Markdown
Contributor Author

It might be worth mentioning somewhere that we use LrHq in case someone is still using older chemistry.

@Ge0rges

Ge0rges commented Mar 23, 2024

Copy link
Copy Markdown
Contributor Author

@wdecoster do you think the PR merits a version bump and package?

@wdecoster

Copy link
Copy Markdown
Owner

Yes, I need to make a new release. Hmm, the older chemistry won't immediately go away. I am not yet sure what the best solution is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants