Fix wrong data type in `defaultcfg.wavelog_id' #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`defaultcfg.wavelog_id' should be a string as main.js L305 trims it.
Contributor
Author
|
Users may enter the server url and and api key in the config tab and click Test. After it turns green, they believe they are good to go on air :-p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
defaultcfg.wavelog_idshould be a string as main.js L305 trims it. Because of the mistypedwavelog_idindefaultcfg,send2wavelogyields a "wavelog_id.trimis not a function" TypeError causing a vague and confusing error "Reason: undefined" on the UI.The two undefined combined together (as shown in the image) may be very confusing to the user tricking them to believe it's an internal bug.
After fixing the mistyped property, it shows an error with reason "missing or wrong api key" which, at least, gives the user some clues about their configurations. It's definitely not the best UX with a careless user but I believe this PR would be the first right step towards it.