Remove object.assign polyfill
#211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `package.json` specifies that this project is targeting Node.js >=10. `Object.assign()` has existed in Node.js since v4.0.0 and browsers around Q1 2015. As such, this polyfill is no longer a direct dependency.
|
|
Contributor
Author
$ uname -m -o
x86_64 GNU/Linux
$ node --version
v16.13.2
$ set -x FIREFOX_BIN librewolf
$ npm test
> [email protected] test
> npm run lint && npm run test-offline
> [email protected] lint
> eslint .
> [email protected] test-offline
> karma start --single-run
28 05 2022 21:09:30.307:INFO [http.server]: Starting
28 05 2022 21:09:30.328:INFO [http.server]: setting up token & api servers for offline test
28 05 2022 21:09:30.329:INFO [http.server]: Done
28 05 2022 21:09:32.255:INFO [framework.browserify]: bundle built
28 05 2022 21:09:32.266:INFO [karma-server]: Karma v6.3.16 server started at http://localhost:9876/
28 05 2022 21:09:32.267:INFO [launcher]: Launching browsers FirefoxAutoGUM with concurrency unlimited
28 05 2022 21:09:32.269:INFO [launcher]: Starting browser Firefox
28 05 2022 21:09:33.683:INFO [Firefox 91.0 (Linux x86_64)]: Connected on socket 7SL1sZSAiIHtaIXZAAAB with id 45381226
Firefox 91.0 (Linux x86_64): Executed 0 of 42 SUCCESS (0 secs / 0 secs)
28 05 2022 21:09:42.040:WARN [http.server]: ::ffff:127.0.0.1 disconnected with 1006 Connection dropped by remoteFirefox 91.0 (Linux x86_64): Executed 1 of 42 SUCCESS (0 secs / 8 secs)
28 05 2022 21:09:42.074:WARN [http.server]: ::ffff:127.0.0.1 disconnected with 1006 Connection dropped by remoteFirefox 91.0 (Linux x86_64): Executed 2 of 42 SUCCESS (0 secs / 8.1 secs)
28 05 2022 21:09:42.100:WARN [http.server]: ::ffff:127.0.0.1 disconnected with 1006 Connection dropped by remoteFirefox 91.0 (Linux x86_64): Executed 3 of 42 SUCCESS (0 secs / 8.1 secs)
28 05 2022 21:09:42.139:WARN [http.server]: ::ffff:127.0.0.1 disconnected with 1006 Connection dropped by remoteFirefox 91.0 (Linux x86_64): Executed 42 of 42 SUCCESS (8.245 secs / 8.2 secs)
TOTAL: 42 SUCCESS |
germanattanasio
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
package.jsonspecifies that this project is targeting Node.jsChecklist
npm testpasses (tip:npm run autofixcan correct most style issues)