Skip to content

Experimental: Update wasmparser to experimental version#656

Closed
Robbepop wants to merge 1 commit intomasterfrom
rf-wasmparser-func-refs-benchmark
Closed

Experimental: Update wasmparser to experimental version#656
Robbepop wants to merge 1 commit intomasterfrom
rf-wasmparser-func-refs-benchmark

Conversation

@Robbepop
Copy link
Copy Markdown
Member

@Robbepop Robbepop commented Feb 7, 2023

This PR commit updates wasmparser to a rev that implements the non-standard function-references Wasm proposal in order to check the performance implications on wasmi Wasm validation.

See comment: bytecodealliance/wasm-tools#701 (comment)

This PR commit updates wasmparser to a rev that implements the non-standard function-references Wasm proposal in order to check the performance implications on wasmi Wasm validation.
@paritytech-cicd-pr
Copy link
Copy Markdown

BENCHMARKS

NATIVEWASMTIME
BENCHMARKMASTERPRDIFFMASTERPRDIFFWASMTIME OVERHEAD
execute/
bare_call_0
1.39ms 1.40ms 🔴 1.11% 1.20ms 1.18ms 🟢 -2.28% 🟢 -16%
execute/
bare_call_0/typed
1.01ms 1.02ms 🔴 1.24% 816.65µs 766.64µs 🟢 -6.11% 🟢 -25%
execute/
bare_call_1
1.43ms 1.43ms 🔴 0.49% 1.36ms 1.36ms 🔴 0.60% 🟢 -5%
execute/
bare_call_16
2.27ms 2.23ms 🔴 -2.11% 4.27ms 4.33ms 🔴 1.42% 🟡 94%
execute/
bare_call_16/typed
1.58ms 1.72ms 🔴 9.26% 2.25ms 2.21ms 🟢 -1.81% 🟢 29%
execute/
bare_call_1/typed
1.11ms 1.12ms ⚪ 1.14% 1.27ms 1.18ms 🟢 -7.00% 🟢 6%
execute/
bare_call_4
1.63ms 1.57ms 🟢 -3.80% 1.94ms 1.95ms 🟢 0.99% 🟢 24%
execute/
bare_call_4/typed
1.11ms 1.13ms ⚪ 0.97% 1.26ms 1.23ms 🟢 -3.06% 🟢 9%
execute/
br_table
1.11ms 1.13ms 🔴 1.63% 1.44ms 1.37ms 🟢 -4.80% 🟢 21%
execute/
count_until
682.17µs 711.36µs 🔴 4.42% 2.13ms 2.13ms ⚪ 0.28% 🔴 200%
execute/
factorial_iterative
326.84µs 361.41µs ⚪ 5.32% 913.09µs 907.96µs ⚪ -0.85% 🔴 151%
execute/
factorial_recursive
800.85µs 664.22µs 🟢 -16.16% 1.35ms 1.35ms ⚪ 0.16% 🔴 104%
execute/
fib_iterative
1.36ms 1.43ms 🔴 5.50% 5.01ms 5.21ms 🔴 4.08% 🔴 265%
execute/
fib_recursive
6.08ms 5.97ms 🟢 -1.86% 12.38ms 12.04ms 🟢 -2.74% 🔴 102%
execute/
global_bump
979.91µs 1.12ms 🔴 13.07% 2.56ms 2.56ms ⚪ 0.11% 🔴 129%
execute/
global_const
737.69µs 778.06µs 🔴 3.53% 2.39ms 2.39ms ⚪ -0.02% 🔴 208%
execute/
host_calls
26.19µs 26.95µs ⚪ 2.32% 41.63µs 37.97µs 🟢 -8.46% 🟢 41%
execute/
memory_fill
1.26ms 1.37ms 🔴 8.86% 4.03ms 4.04ms ⚪ 0.50% 🔴 196%
execute/
memory_sum
1.32ms 1.41ms ⚪ 6.29% 4.01ms 4.01ms ⚪ 0.10% 🔴 185%
execute/
memory_vec_add
2.50ms 2.55ms 🔴 2.08% 7.66ms 7.64ms ⚪ -0.28% 🔴 200%
execute/
recursive_is_even
1.20ms 1.14ms ⚪ -2.66% 2.26ms 2.24ms ⚪ -1.02% 🟡 97%
execute/
recursive_ok
159.11µs 152.79µs 🟢 -4.39% 311.61µs 308.71µs ⚪ -0.56% 🔴 102%
execute/
recursive_scan
187.01µs 182.70µs ⚪ -1.86% 398.44µs 397.46µs ⚪ -0.81% 🔴 118%
execute/
recursive_trap
15.66µs 15.08µs 🟢 -4.13% 30.62µs 30.75µs ⚪ 0.41% 🔴 104%
execute/
regex_redux
553.56µs 545.89µs 🟢 -1.39% 1.37ms 1.37ms ⚪ 0.08% 🔴 152%
execute/
rev_complement
474.26µs 493.64µs 🔴 4.04% 1.41ms 1.39ms ⚪ -0.87% 🔴 183%
execute/
tiny_keccak
334.10µs 354.10µs 🔴 6.16% 1.14ms 1.14ms ⚪ 0.00% 🔴 223%
execute/
trunc_f2i
721.96µs 732.16µs 🔴 1.37% 2.15ms 2.15ms ⚪ -0.06% 🔴 194%
instantiate/
wasm_kernel
65.44µs 64.66µs 🟢 -1.81% 72.98µs 68.55µs ⚪ -2.84% 🟢 6%
translate/
erc1155
208.31µs 219.26µs 🔴 5.17% 388.23µs 395.26µs ⚪ 1.28% 🟡 80%
translate/
erc20
103.19µs 109.42µs 🔴 6.12% 190.34µs 199.18µs 🔴 4.66% 🟡 82%
translate/
erc721
147.59µs 154.18µs 🔴 4.73% 279.29µs 282.69µs ⚪ -0.36% 🟡 83%
translate/
spidermonkey
0.00ns 0.00ns 🔴 4.87% 0.00ns 0.00ns 🔴 1.52% 🟢 0%
translate/
wasm_kernel
3.77ms 3.99ms 🔴 6.09% 7.43ms 7.46ms ⚪ 0.67% 🟡 87%

Link to pipeline

@Robbepop
Copy link
Copy Markdown
Member Author

Robbepop commented Feb 8, 2023

Experiment concluded. Closed.

@Robbepop Robbepop closed this Feb 8, 2023
@Robbepop Robbepop deleted the rf-wasmparser-func-refs-benchmark branch March 11, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants