Skip to content

Add GestureEvent (a WebKit proprietary interface for multitouch)#4589

Merged
daxpedda merged 4 commits intowasm-bindgen:mainfrom
thatcomputerguy0101:gesture-event
Sep 3, 2025
Merged

Add GestureEvent (a WebKit proprietary interface for multitouch)#4589
daxpedda merged 4 commits intowasm-bindgen:mainfrom
thatcomputerguy0101:gesture-event

Conversation

@thatcomputerguy0101
Copy link
Copy Markdown
Contributor

@thatcomputerguy0101 thatcomputerguy0101 commented Aug 20, 2025

GestureEvent is a WebKit proprietary interface for receiving multitouch pinch and rotation gestures. The information for the WebIDL was gathered from https://developer.apple.com/documentation/webkitjs/gestureevent.

I assumed this needed to be in unstable and not enabled due to being a non-standard API, but that does limit its usability.

@thatcomputerguy0101 thatcomputerguy0101 mentioned this pull request Aug 20, 2025
Merged
daxpedda
daxpedda requested changes Aug 25, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just missing a changelog entry.

daxpedda
daxpedda approved these changes Sep 3, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@daxpedda daxpedda enabled auto-merge (squash) September 3, 2025 16:25
@daxpedda daxpedda merged commit 038c589 into wasm-bindgen:main Sep 3, 2025
66 checks passed
@thatcomputerguy0101
Copy link
Copy Markdown
Contributor Author

thatcomputerguy0101 commented Sep 4, 2025

I thought the [BinaryName="clientX"] line allowed the JS name and the Rust name to be separate. I didn't realize it was just a browser-specific attribute. Those two fields should be named clientX and clientY instead of x and y, which I have changed on the branch this PR was created from. Should I create a new PR?

@daxpedda
Copy link
Copy Markdown
Member

daxpedda commented Sep 4, 2025

I thought the [BinaryName="clientX"] line allowed the JS name and the Rust name to be separate.

Why should they be separate in this case? Shouldn't they always be named clientX/clientY?

Should I create a new PR?

Yes please!

I also noticed that we got the constructor wrong. This type doesn't seem to have a constructor, but initGestureEvent is just a method, similar to initMouseEvent.

@thatcomputerguy0101
Copy link
Copy Markdown
Contributor Author

thatcomputerguy0101 commented Sep 4, 2025

Why should they be separate in this case? Shouldn't they always be named clientX/clientY?

They shouldn't be separate. I had inferred conventions that don't exist.

I also noticed that we got the constructor wrong. This type doesn't seem to have a constructor, but initGestureEvent is just a method, similar to initMouseEvent.

I will also fix that in the next PR.

@thatcomputerguy0101 thatcomputerguy0101 mentioned this pull request Sep 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxpedda daxpedda daxpedda approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thatcomputerguy0101 @daxpedda