Remove blocklist markdown images from preview flags#9993
Conversation
The feature was already compiled into Stable via the default Cargo feature list, so keeping it in PREVIEW_FLAGS only makes it appear as Preview-exclusive in the changelog. Co-Authored-By: Oz <[email protected]>
|
I'm starting a first review of this pull request. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR removes FeatureFlag::BlocklistMarkdownImages from PREVIEW_FLAGS, aligning the preview-only flag list with the already-enabled default Cargo feature path for Stable builds.
Concerns
- No blocking correctness, security, or spec-alignment concerns found in the changed hunk.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
## Description This removes `FeatureFlag::BlocklistMarkdownImages` from `PREVIEW_FLAGS`. We accidentally promoted inline Markdown image rendering in the AI block list to Stable in the latest release because `blocklist_markdown_images` is already enabled in the default Cargo feature list. This PR aligns the runtime flag lists with that Stable enablement path so the feature is no longer treated as Preview-exclusive. Mermaid rendering is also already enabled for Stable via the default `markdown_mermaid` Cargo feature. Together, these defaults allow Stable builds to render inline Markdown images and Mermaid diagrams in agent block output. ## Linked Issue N/A ## Screenshots / Videos N/A — flag-list cleanup only. ## Testing - `cargo fmt` - `cargo clippy --workspace --all-targets --all-features --tests -- -D warnings` Note: the first clippy attempt failed before Rust checks because `command-signatures-v2` required Yarn 4 via Corepack while the shell had Yarn 1.22. I ran `corepack enable` and reran clippy successfully. ## Agent Mode - [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode ## Changelog Entries for Stable CHANGELOG-IMPROVEMENT: Warp now renders inline local images and Mermaid diagrams in agent block output. Co-Authored-By: Oz <[email protected]> Agent artifacts: - Conversation: https://staging.warp.dev/conversation/7967da60-8ae2-4747-9db4-3bb49f727a32 Co-authored-by: Oz <[email protected]>
|
I'm re-reviewing this pull request in response to a review request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
|
I'm re-reviewing this pull request in response to a review request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR removes FeatureFlag::BlocklistMarkdownImages from PREVIEW_FLAGS, which aligns the Preview runtime list with the existing default Cargo feature enablement for stable builds.
Concerns
- No blocking correctness or security concerns found in the changed hunk.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
There was a problem hiding this comment.
Overview
This PR removes FeatureFlag::BlocklistMarkdownImages from PREVIEW_FLAGS so the preview changelog and channel-specific feature list no longer treat inline block-list Markdown image rendering as Preview-exclusive. The compiled default feature still maps to the runtime BlocklistMarkdownImages flag through enabled_features(), so Stable builds keep the behavior described in the PR.
Concerns
- No blocking correctness or security concerns found in the changed hunk.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
2 participants
Description
This removes
FeatureFlag::BlocklistMarkdownImagesfromPREVIEW_FLAGS.We accidentally promoted inline Markdown image rendering in the AI block list to Stable in the latest release because
blocklist_markdown_imagesis already enabled in the default Cargo feature list. This PR aligns the runtime flag lists with that Stable enablement path so the feature is no longer treated as Preview-exclusive.Mermaid rendering is also already enabled for Stable via the default
markdown_mermaidCargo feature. Together, these defaults allow Stable builds to render inline Markdown images and Mermaid diagrams in agent block output.Linked Issue
N/A
Screenshots / Videos
N/A — flag-list cleanup only.
Testing
cargo fmtcargo clippy --workspace --all-targets --all-features --tests -- -D warningsNote: the first clippy attempt failed before Rust checks because
command-signatures-v2required Yarn 4 via Corepack while the shell had Yarn 1.22. I rancorepack enableand reran clippy successfully.Agent Mode
Changelog Entries for Stable
CHANGELOG-IMPROVEMENT: Warp now renders inline local images and Mermaid diagrams in agent block output.
Co-Authored-By: Oz [email protected]
Agent artifacts: